Cleanup nvidia ctk installer #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
cleanup-nvidia-ctk-installer
branch
from
a077175 to
4fe5933
Compare
elezar
requested review from
ArangoGutierrez,
cdesiniotis,
jgehrcke and
tariq1890
ArangoGutierrez
approved these changes
Mar 14, 2025
The GPU Operator no longer sets the RUNTIME_ARGS environment variable to control the runtime and instead sets general environment variables. This change removes support for setting RUNTIME_ARGS in the CLI as these settings have no effect. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Parsing positional arguments require additional processing instead of relying on named flags. This change switches to using a named flag for specifying the toolkit installation directory. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
cleanup-nvidia-ctk-installer
branch
from
4fe5933 to
75a30af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes perform minor cleanups to the
nvidia-ctk-installerbinary.The changes include:
RUNTIME_ARGSenvvar since these are no longer used in the code.--toolkit-install-dir(--root) argument instead of attempting to parse positional arguments.