Do not record the timestamp in gzip file #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recording timestamps makes nvidia-settings unreproducible, adding -n as argument makes gzip not record a timestamp and filename.
|
Thanks for this. I applied this change and equivalent changes to the other related projects to our internal codebase. It'll take a while for it to show up in an official release but I'll merge this here. |
|
Thansk! |
|
btw: with gzip-1.10, this should be reproducible even without the patch, because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Recording timestamps makes nvidia-settings unreproducible, adding -n as
argument makes gzip not record a timestamp and filename.
Motivation: https://reproducible-builds.org/