feat(operator): changed interrupt order #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement New Interrupt Package Ordering
Summary
Changes interrupt package ordering to cordon, wait, and drain nodes before applying packages, rather than after. This critical change aligns with user expectations and enables safe execution of operations requiring exclusive system access.
Problem Statement
Previously, the interrupt package order was: apply → config → cordon → wait → drain → interrupt
This ordering was problematic because:
Solution
Code Changes: Modified the interrupt flow in the Skyhook controller to implement the new ordering
Documentation Changes: Updated all documentation to reflect the new interrupt package order
New Order: cordon → wait → drain → apply → config → interrupt
This ensures:
Use Case Example
GPU Mode Switching Scenario:
Changes Made
Code Changes
operator/internal/controller/skyhook_controller.go: Modified interrupt flow logic to cordon and drain nodes before package applicationProcessInterrupt()andEnsureNodeIsReadyForInterrupt()functions to implement new orderingDocumentation Updates
docs/operator-status-definitions.md: Updated stage flow diagrams to show correct interrupt orderingREADME.md: Clarified stage ordering differences between interrupt and non-interrupt packagesdocs/interrupt_flow.md:docs/README.md: Added reference to new interrupt flow documentationKey Ordering Changes