Conversation
Signed-off-by: Dmitry Shmulevich <dshmulevich@nvidia.com>
Contributor
Greptile SummaryAdds Prometheus ServiceMonitor support to the Helm chart, enabling automated metrics collection by the Prometheus Operator. The implementation includes a new template file with proper conditional rendering and a configuration block in values.yaml with sensible defaults (disabled by default, 15s interval, Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as User/Admin
participant Helm as Helm Chart
participant K8s as Kubernetes API
participant SM as ServiceMonitor
participant Prometheus as Prometheus Operator
participant Svc as Topograph Service
participant App as Topograph App
User->>Helm: helm install/upgrade with serviceMonitor.enabled=true
Helm->>K8s: Create ServiceMonitor resource
K8s->>SM: ServiceMonitor created in monitoring namespace
Prometheus->>SM: Watch for ServiceMonitor resources
SM-->>Prometheus: ServiceMonitor configuration
Prometheus->>Svc: Discover Service via selector labels
Prometheus->>App: Scrape /metrics on http port every 15s
App-->>Prometheus: Return Prometheus metrics
Note over Prometheus: Metrics stored and available for querying
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 65.71% 65.71%
=======================================
Files 78 78
Lines 4290 4290
=======================================
Hits 2819 2819
Misses 1362 1362
Partials 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.