Skip to content

fix(topograph): tune topology request latency buckets for better percentile accuracy#215

Merged
dmitsh merged 1 commit into
mainfrom
ds-hist
Feb 12, 2026
Merged

fix(topograph): tune topology request latency buckets for better percentile accuracy#215
dmitsh merged 1 commit into
mainfrom
ds-hist

Conversation

@dmitsh
Copy link
Copy Markdown
Collaborator

@dmitsh dmitsh commented Feb 12, 2026

No description provided.

…entile accuracy

Signed-off-by: Dmitry Shmulevich <dshmulevich@nvidia.com>
@dmitsh dmitsh requested a review from ravisoundar February 12, 2026 21:25
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

This PR replaces Prometheus default buckets (0.005 to 10 seconds) with custom buckets (1 to 30 seconds) for the topograph_request_duration_seconds histogram. The new buckets are better suited for topology request latencies which typically take several seconds to complete.

  • Changed histogram buckets from prometheus.DefBuckets to custom range [1, 2.5, 5, 7.5, 10, 12.5, 15, 17.5, 20, 25, 30] seconds
  • Improves percentile accuracy (p50, p90, p95, p99) for topology requests which are inherently slower than HTTP requests
  • HTTP request metrics still use default buckets, which is appropriate for faster operations

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, well-scoped metrics configuration update that replaces default Prometheus histogram buckets with domain-specific buckets. The new buckets (1-30 seconds) align with the expected latency range for topology requests, improving observability without affecting functionality.
  • No files require special attention

Important Files Changed

Filename Overview
pkg/metrics/metrics.go Replaced default Prometheus buckets with custom buckets (1-30 seconds) tailored for topology request latencies

Last reviewed commit: f318ae1

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.94%. Comparing base (89c4290) to head (f318ae1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   65.94%   65.94%           
=======================================
  Files          82       82           
  Lines        4493     4493           
=======================================
  Hits         2963     2963           
  Misses       1418     1418           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@ravisoundar ravisoundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dmitsh dmitsh merged commit c4787f7 into main Feb 12, 2026
6 checks passed
@dmitsh dmitsh deleted the ds-hist branch February 12, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants