Skip to content

Nebius GoSDK integration enhancement#227

Merged
dmitsh merged 2 commits into
NVIDIA:mainfrom
complynx:nebius_integration_enhancement
Mar 4, 2026
Merged

Nebius GoSDK integration enhancement#227
dmitsh merged 2 commits into
NVIDIA:mainfrom
complynx:nebius_integration_enhancement

Conversation

@complynx
Copy link
Copy Markdown
Contributor

@complynx complynx commented Mar 4, 2026

No description provided.

@complynx complynx requested a review from dmitsh as a code owner March 4, 2026 11:42
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 4, 2026

Greptile Summary

This PR enhances the Nebius provider integration by upgrading github.com/nebius/gosdk from a pseudo-version to the proper semver release v0.2.0, and uses the newly available gosdk.WithUserAgentPrefix option to identify outgoing API requests with the nvidia-topograph product name and version. It also bumps google.golang.org/protobuf to v1.36.11 and the associated buf.build indirect dependency.

Key changes:

  • Upgrades github.com/nebius/gosdk from pseudo-version v0.0.0-20250925083101-fd7444ff5a96 to v0.2.0 (first proper release)
  • Adds getUserAgentPrefix(version string) string helper that produces nvidia-topograph or nvidia-topograph/<version> depending on whether a version is set
  • Wires the helper into gosdk.New(...) so all Nebius API calls carry an identifying User-Agent prefix
  • Adds TestGetUserAgentPrefix covering empty, whitespace-only, and normal version strings
  • Dependency updates are straightforward and well-tested

The changes are well-scoped, clearly tested, and the dependency upgrade is straightforward. No issues identified.

Confidence Score: 5/5

  • PR is safe to merge; changes are well-scoped, tested, and dependency upgrades are straightforward.
  • All changes are focused, properly tested, and follow good practices. Dependency upgrades are to stable releases. The implementation of the User-Agent prefix feature is correct and integrates cleanly with the existing codebase. No functional or structural issues identified.
  • No files require special attention.

Last reviewed commit: 71ff004

@dmitsh
Copy link
Copy Markdown
Collaborator

dmitsh commented Mar 4, 2026

@complynx , please add "signed-off-by" to your commit (git commit -s)

Signed-off-by: Daniel D <d.drizhuk@gmail.com>
@complynx complynx force-pushed the nebius_integration_enhancement branch from a7d2bd5 to ad824e5 Compare March 4, 2026 16:42
@complynx
Copy link
Copy Markdown
Contributor Author

complynx commented Mar 4, 2026

@complynx , please add "signed-off-by" to your commit (git commit -s)

Done

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.38%. Comparing base (981ff93) to head (71ff004).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/providers/nebius/provider.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   66.35%   66.38%   +0.02%     
==========================================
  Files          82       82              
  Lines        4559     4563       +4     
==========================================
+ Hits         3025     3029       +4     
  Misses       1415     1415              
  Partials      119      119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitsh
Copy link
Copy Markdown
Collaborator

dmitsh commented Mar 4, 2026

@complynx, some minor issue with formatting. PTAL

Signed-off-by: Daniel D <d.drizhuk@gmail.com>
@dmitsh
Copy link
Copy Markdown
Collaborator

dmitsh commented Mar 4, 2026

@complynx , thank you for your contribution

@dmitsh dmitsh merged commit ab68b6c into NVIDIA:main Mar 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants