Skip to content

fix(k8s): update resource requests and limits#231

Merged
dmitsh merged 1 commit into
mainfrom
ds-k8s-res
Mar 5, 2026
Merged

fix(k8s): update resource requests and limits#231
dmitsh merged 1 commit into
mainfrom
ds-k8s-res

Conversation

@dmitsh
Copy link
Copy Markdown
Collaborator

@dmitsh dmitsh commented Mar 5, 2026

No description provided.

Signed-off-by: Dmitry Shmulevich <dshmulevich@nvidia.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 5, 2026

Greptile Summary

This PR increases the Kubernetes resource requests and limits for both the topograph main chart and the node-observer sub-chart, addressing previously under-provisioned defaults.

  • CPU limit raised from 100m400m (4×) in both charts
  • Memory limit raised from 128Mi512Mi (4×) in both charts
  • CPU request raised from 100m250m in both charts
  • Memory request raised from 128Mi256Mi in both charts
  • The change transitions pods from Guaranteed QoS class (requests == limits) to Burstable QoS class (requests < limits), allowing bursting up to the defined limits under load while scheduling on the lower requests values — this is a common best practice for variable-load workloads.

Confidence Score: 5/5

  • Safe to merge — only adjusts Helm chart resource defaults with no logic changes.
  • This PR is safe to merge. It only modifies Helm values files to update resource requests and limits. The changes are limited to two files, the new values are internally consistent (requests < limits in both charts), follow Kubernetes best practices, and are symmetric across both the main chart and the sub-chart. No logic, templates, or application code is touched.
  • No files require special attention.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before["Before (Guaranteed QoS)"]
        A1["topograph\nCPU req/limit: 100m\nMemory req/limit: 128Mi"]
        B1["node-observer\nCPU req/limit: 100m\nMemory req/limit: 128Mi"]
    end

    subgraph After["After (Burstable QoS)"]
        A2["topograph\nCPU req: 250m / limit: 400m\nMemory req: 256Mi / limit: 512Mi"]
        B2["node-observer\nCPU req: 250m / limit: 400m\nMemory req: 256Mi / limit: 512Mi"]
    end

    Before -->|"Resource update"| After
Loading

Last reviewed commit: 2c5104f

@dmitsh dmitsh merged commit ab75b07 into main Mar 5, 2026
4 checks passed
@dmitsh dmitsh deleted the ds-k8s-res branch March 5, 2026 22:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.52%. Comparing base (4fa83d6) to head (2c5104f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files          82       82           
  Lines        4562     4562           
=======================================
  Hits         3035     3035           
  Misses       1411     1411           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant