Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #100. Fix CAN_Type* in FLEXCAN2 ISR #101

Merged
merged 1 commit into from Feb 9, 2023

Conversation

weinshec
Copy link
Contributor

@weinshec weinshec commented Dec 6, 2022

The FLEXCAN driver uses an apparently wrong CAN_Type*/base address as argument to the s_flexcanIsr handler for interrupts on FLEXCAN2. This change makes the CAN_FD2_DriverIRQHandler use the correct base address.

Prerequisites

  • I have checked latest main branch and the issue still exists.
  • I did not see it is stated as known-issue in release notes.
  • No similar GitHub issue is related to this change.
  • My code follows the commit guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

Describe the pull request
Use correct base address pointer in CAN_FD2_DriverIRQHandler of the flexcan driver.
Fixes #100

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Tests

  • Test configuration (please complete the following information):
    • Hardware setting: MIMX8ML8
    • Toolchain: arm-none-eabi-gcc 12.2.0
    • Test Tool preparation:
    • Any other dependencies:
  • Test executed
    Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
    • Build Test
    • Run Test
      Try to send or receive any CAN frame on FLEXCAN2 using the transactional API

The FLEXCAN driver uses an apparently wrong CAN_Type*/base address as
argument to the `s_flexcanIsr` handler for interrupts on FLEXCAN2. This
change makes the `CAN_FD2_DriverIRQHandler` use the correct base
address.

Signed-off-by: Christoph Weinsheimer <christoph.weinsheimer@advastore.com>
@mcuxcc mcuxcc merged commit bfda093 into nxp-mcuxpresso:main Feb 9, 2023
@weinshec weinshec deleted the bugfix/fixing_100 branch February 9, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FLEXCAN driver uses wrong base address argument in FLEXCAN2 IRQ Handler
3 participants