Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12355 Set up LU Housing Plans section #699

Merged
merged 1 commit into from Sep 14, 2020

Conversation

godfreyyeung
Copy link
Contributor

@godfreyyeung godfreyyeung commented Sep 12, 2020

Summary

Sets up the first part of the LU Housing Plans section. This first part only PATCHes to dcp_landuse, and not another entity (like dcp_sitedatahform)

Which major feature does this fit into?

Land Use -- House Plans
Fixes AB#12355

Technical Explanation — How does it work?

  • Very similar to previous components with cascading forms.
  • For these housing plan optionsets, I extended them from COMMON_OPTIONSETS.YES_NO optionsets.
    These housing plan optionsets are essentially YES_NO optionsets; they share the same code values but have a slightly customized labels.

@godfreyyeung godfreyyeung requested a review from a team as a code owner September 12, 2020 03:47
@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #699 into landuse-form will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           landuse-form     #699      +/-   ##
================================================
+ Coverage         92.67%   92.76%   +0.09%     
================================================
  Files                76       76              
  Lines               560      567       +7     
================================================
+ Hits                519      526       +7     
  Misses               41       41              
Impacted Files Coverage Δ
client/app/helpers/optionset.js 100.00% <ø> (ø)
client/app/models/landuse-form.js 86.20% <ø> (ø)
client/app/optionsets/common.js 100.00% <100.00%> (ø)
client/app/optionsets/landuse-form.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4853c40...aafed57. Read the comment docs.

@godfreyyeung godfreyyeung merged commit 3eaedfc into landuse-form Sep 14, 2020
@godfreyyeung godfreyyeung deleted the 12355-lu-housing-plans branch September 14, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants