I think this is what you were looking for. An error message now gets logged to terminal.
fix for issue #38
I think it would be better to put the logging closer to the code that interacts with the API (i.e., APIWrapper), that way we don't need to repeat it everywhere we call one of these methods. There is also some benefit to performing this logging action in one place should different parts of the application use different logging settings.
Also don't forget to add yourself to AUTHORS.rst.
It seems to me like the logic represented here would handle @dirn's comments and more if moved into APIWrapper._get. Specifically, if we replace line 36 with the log-and-return-empty-list logic, we'll be covered on both the current and any future request types. This also ensures that one request's failure doesn't mask another's success.
Merge remote-tracking branch 'origin/master'
changed up my logging slightly.
There seems to be a lot going on here now. I think this pull request should focus on just #38, logging the error and returning an empty list.
removed all the extra stuff not related to issue #38. fixed up the lo…
…g-and-return-empty-logic on line 36 per jonafato and dirns suggestions
Yea, sorry about that. I was trying to commit back to my branch for my own reference and didn't realize it also was getting pulled into this request. Updated my commit and removed all the extra stuff and now it should return an empty list.
Almost there. meetup_api_logger is undefined.
corrected incorrect variable name
Lets try this one last time. Changed the incorrect variable reference to _logger now.