This repository has been archived by the owner on Oct 27, 2023. It is now read-only.
SCC-2271 Fix legacy i field holding parsing #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The importing of the Format (e.g. "PRINT") from the holding record comes from the `i` field, either as a legacy field or from the MARC `843` field. When imported from the legacy field this was being set as an array. This simply corrects that issue and adds a new test. This was not caught earlier because the `assert.equal` call evaluated `['PRINT']` and `PRINT` as equal. Adding the `assert.strictEqual` check instead raised the error. This should be carried forward for all new tests written.
nonword
approved these changes
Oct 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The importing of the Format (e.g. "PRINT") from the holding record comes from the
ifield, either as a legacy field or from the MARC843field. When imported from the legacy field this was being set as an array. This simply corrects that issue and adds a new test.This does not cause a fatal error but instead for many Format strings to appear in the front end as
{"PRINT"}as they are stored as arrays in the PCDM.This was not caught earlier because the
assert.equalcall evaluated['PRINT']andPRINTas equal. Adding theassert.strictEqualcheck instead raised the error. This should be carried forward for all new tests written.