Fix reading file with a path relative to HOME #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but you're right we need tests. We should set "$HOME" to point to |
basile-henry
force-pushed
the
fix-home-import
branch
from
f18d2d9
to
12e99c7
Compare
|
Looks perfect! |
|
Sorry if I am being too impatient, but are you able to share an approximate timeline of the next release that includes this fix? PS: my interest in having this fix rolled out is due to s-zeng/dhall-python#41 |
|
@padhia oh yeah don't hesistate to ask! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223
We need to actually resolve the
~in the path, this is not something supported by thestd::fs::FileAPI.It looks like
dhall-haskelldoes this as well:https://github.com/dhall-lang/dhall-haskell/blob/14ae4296874fa9bdd4b585f0ef82d43cff36b091/dhall/src/Dhall/Import.hs#L475-L477
Maybe we should add some tests to cover this?
At the moment all import tests are relative, doing otherwise in the
dhall-langrepo would be tricky as it would rely on knowing where the file are located.But we should be able to do the following in this test suite: for all import tests, parse and convert imports to absolute imports and to relative to home imports, serialize and then test that.