New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode is duplicated #99

Closed
jasonLaster opened this Issue Jan 22, 2017 · 4 comments

Comments

3 participants
@jasonLaster

jasonLaster commented Jan 22, 2017

It shows up twice on the list:

screen shot 2017-01-21 at 11 06 56 pm

@7c6f434c

This comment has been minimized.

Show comment
Hide comment
@7c6f434c

7c6f434c Jan 22, 2017

And I think the list has two different mirrors of LLVM.

7c6f434c commented Jan 22, 2017

And I think the list has two different mirrors of LLVM.

@Nagasaki45

This comment has been minimized.

Show comment
Hide comment
@Nagasaki45

Nagasaki45 Jan 23, 2017

Owner

@jasonLaster, this is a bug. I will handle it soon. Meanwhile, I deleted one of the instances manually.

@7c6f434c, you are right, but there is nothing I can do against it. With the simple metric I use they both look like legitimate projects on GitHub that worth tracking. If you have an idea of how to detect the "unofficial" automatically do tell.

Owner

Nagasaki45 commented Jan 23, 2017

@jasonLaster, this is a bug. I will handle it soon. Meanwhile, I deleted one of the instances manually.

@7c6f434c, you are right, but there is nothing I can do against it. With the simple metric I use they both look like legitimate projects on GitHub that worth tracking. If you have an idea of how to detect the "unofficial" automatically do tell.

@7c6f434c

This comment has been minimized.

Show comment
Hide comment
@7c6f434c

7c6f434c Jan 25, 2017

It is hard to define «unofficial», but I am not complaining about Chromium here. The only formal definition that would make some sense is being developed on GitHub, i.e. at least one PR in the last year or something like that. That would limit the scope, of course, so that's just a judgement call, not a bug fix.

As for the bug with clones: I am not sure about feasibility with the current API, but I would fetch the master commits from 1th December 2016 (the latest 1st that is more than a month ago) and look for intersections. If two LLVMs have had the same master branch a month ago, pick the higher-ranking one. Maybe add a small note «there are other instances of the same project» if you feel like that.

7c6f434c commented Jan 25, 2017

It is hard to define «unofficial», but I am not complaining about Chromium here. The only formal definition that would make some sense is being developed on GitHub, i.e. at least one PR in the last year or something like that. That would limit the scope, of course, so that's just a judgement call, not a bug fix.

As for the bug with clones: I am not sure about feasibility with the current API, but I would fetch the master commits from 1th December 2016 (the latest 1st that is more than a month ago) and look for intersections. If two LLVMs have had the same master branch a month ago, pick the higher-ranking one. Maybe add a small note «there are other instances of the same project» if you feel like that.

@Nagasaki45

This comment has been minimized.

Show comment
Hide comment
@Nagasaki45

Nagasaki45 Jan 25, 2017

Owner

These are good propositions! I opened a separate ticket for handling them (#102). The vscode issue is really a simple bug that I need to fix. Let's keep the current ticket for that issue and move the discussion to the new thread.

Owner

Nagasaki45 commented Jan 25, 2017

These are good propositions! I opened a separate ticket for handling them (#102). The vscode issue is really a simple bug that I need to fix. Let's keep the current ticket for that issue and move the discussion to the new thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment