Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upVSCode is duplicated #99
Comments
Nagasaki45
added
the
type: bug
label
Jan 22, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
7c6f434c
commented
Jan 22, 2017
|
And I think the list has two different mirrors of LLVM. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Nagasaki45
Jan 23, 2017
Owner
@jasonLaster, this is a bug. I will handle it soon. Meanwhile, I deleted one of the instances manually.
@7c6f434c, you are right, but there is nothing I can do against it. With the simple metric I use they both look like legitimate projects on GitHub that worth tracking. If you have an idea of how to detect the "unofficial" automatically do tell.
|
@jasonLaster, this is a bug. I will handle it soon. Meanwhile, I deleted one of the instances manually. @7c6f434c, you are right, but there is nothing I can do against it. With the simple metric I use they both look like legitimate projects on GitHub that worth tracking. If you have an idea of how to detect the "unofficial" automatically do tell. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
7c6f434c
Jan 25, 2017
It is hard to define «unofficial», but I am not complaining about Chromium here. The only formal definition that would make some sense is being developed on GitHub, i.e. at least one PR in the last year or something like that. That would limit the scope, of course, so that's just a judgement call, not a bug fix.
As for the bug with clones: I am not sure about feasibility with the current API, but I would fetch the master commits from 1th December 2016 (the latest 1st that is more than a month ago) and look for intersections. If two LLVMs have had the same master branch a month ago, pick the higher-ranking one. Maybe add a small note «there are other instances of the same project» if you feel like that.
7c6f434c
commented
Jan 25, 2017
|
It is hard to define «unofficial», but I am not complaining about Chromium here. The only formal definition that would make some sense is being developed on GitHub, i.e. at least one PR in the last year or something like that. That would limit the scope, of course, so that's just a judgement call, not a bug fix. As for the bug with clones: I am not sure about feasibility with the current API, but I would fetch the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Nagasaki45
Jan 25, 2017
Owner
These are good propositions! I opened a separate ticket for handling them (#102). The vscode issue is really a simple bug that I need to fix. Let's keep the current ticket for that issue and move the discussion to the new thread.
|
These are good propositions! I opened a separate ticket for handling them (#102). The vscode issue is really a simple bug that I need to fix. Let's keep the current ticket for that issue and move the discussion to the new thread. |
jasonLaster commentedJan 22, 2017
It shows up twice on the list: