nsca can exit due to ECONNABORTED on FreeBSD

[leres]

We've had a lot of problems on our FreeBSD systems with the nsca daemon exiting due to ECONNABORTED. This is probably caused by cyber security scanning tickling a race condition in nsca itself.

The FreeBSD accept(2) man page says:

 [ECONNABORTED] A connection arrived, but it was closed while waiting on the listen queue.

Here is a minimal patch. A better fix would be to never treat accept(2) errors as fatal.

[jfrickson]

Looking into it.

[ghost]

I may be hitting this at work as well. Patched locally, will see if this solves the unexpected NSCA daemon shutdowns.

[hedenface]

@feld What did you find? Did this solve your issue?

[ghost]

I can confirm this fixed the issue and is no longer crashing. We are shipping this patch with NSCA on FreeBSD

[xavierba]

@hedenface, the patch above looks like it has been tested, fixes the issue, and FreeBSD ships it for more than 2 years. This is likely valid for other platforms as well.
Can you please consider committing it ?

[xavierba]

I filed #39 with the patch rebased against maint branch.

[sawolf]

PR was merged - closing