Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDL_Joystick interface because not all joysticks are SDL_Controller compatible #141

Merged
merged 1 commit into from Oct 21, 2017

Conversation

vanfanel
Copy link
Contributor

@vanfanel vanfanel commented Oct 7, 2017

Hi David:

I have added back SDL_Joystick interface code, because not all joysticks are compatible with the SDL_GameController interface. For example, my PS1 original pads are not compatible with SDL_GameController, and several wired USB joysticks I have around are also incompatible.
So here is the fix.

@NagyD
Copy link
Owner

NagyD commented Oct 15, 2017

Just to be sure, did you test that this doesn't break controllers that do support SDL_Controller?

@vanfanel
Copy link
Contributor Author

Yes. All this patch does is create an SDL_Joystick interface ONLY when the SDL_GameController interface does not support that joystick (when it's not present in SDL_gamecontrollerdb.h).
My PSX adapter is now added into SDL_gamecontrollerdb.h, so I have no personal need for this anymore: my PSX pads are SDL_GameController compatible now, and they work perfectly well with this patch.
Anyway, if someone for some reason unknown to me says that it's causing some missbehaviour when using an SDL_GameController compatible device, I'll be the first to admit I was wrong. But it's simple stuff really :)

@NagyD NagyD merged commit 960cbb4 into NagyD:master Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants