New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Emulate view helper not called #2

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@patrickbroens
Copy link
Contributor

patrickbroens commented Jan 19, 2019

When a non-tag emulate view helper is used, no content is returned. This is due to the fact the closure to render the children is null.

This patch fixes this by returning the content which is calculated before instead of calling the renderChildrenClosure, which is null.

[BUGFIX] Emulate view helper not called
When a non-tag emulate view helper is used, no content is returned. This is due to the fact the closure to render the children is null.

This patch fixes this by returning the content which is calculated before instead of calling the renderChildrenClosure, which is null.
@NamelessCoder

This comment has been minimized.

Copy link
Owner

NamelessCoder commented Jan 30, 2019

Thanks Patrick! Returning tag/child content is of course supposed to be supported also for non-tag-VH.

@NamelessCoder NamelessCoder merged commit fc12219 into NamelessCoder:master Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment