Move NancyOwinHost to core.

[khellang]

I think it's time we address this and start a discussion on how to structure/package things moving forward, and what better way to do that than with a pull request? 😉

This PR renamesNancyOwinHost to NancyMiddleware and moves it to the core project, (still) under the Nancy.Owin namespace.
The AppBuilderExtensions are left intact in the Nancy.Owin project. API-wise, this is not even a breaking change 👍

I also added extensions for the Action<Func<AppFunc, AppFunc>> approach for adding middleware, used in the new IBuilder.UseOwin extensions. This means that you can now do

public void Configure(IBuilder app)
{
    app.UseOwin(owin => owin.UseNancy());
}

in ASP.NET vNext, without other dependencies than core Nancy 👯

Fixes #1387

[jchannon]

Put usings under the namspaces declaration human stylecop strike

[grumpydev]

zOMG! Good job @thecodejunkie isn't watching!

[khellang]

Problem is then you have to declare the Funcs with full names, e.g.

using AppFunc = System.Func<System.Collections.Generic.IDictionary<string, object>, System.Threading.Tasks.Task>

So I think it's worth the tradeoff (what is the tradeoff, exactly? 😝)...

[grumpydev]

Tbh, the funcs in owin are so much smaller these days I'm not sure I see the point in aliasing them.

[grumpydev]

And the tradeoff is that putting them inside the namespace scopes them correctly, which can avoid issues with namespace collisions.. on the flip side, putting them outside of the namespace gets you stabbed in the belly by @thecodejunkie, who will grow a Sparta-eque beard just for the occasion.

Swings and roundabouts really.

[damianh]

The latter is what turns up in intellisense though.
On 28 May 2014 09:26, "Kristian Hellang" notifications@github.com wrote:

In src/Nancy/Owin/DelegateExtensions.cs:

@@ -0,0 +1,48 @@
+using System;

the funcs in owin are so much smaller these days I'm not sure I see the
point in aliasing them.

It looks a bit nicer with

UseNancy(this Action)

than

UseNancy(this Action<Func<IDictionary<string, object>, Task>, Func<IDictionary<string, object>, Task>>)

[image: 😉]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1544/files#r13118572
.

[damianh]

https://groups.google.com/d/msg/net-http-abstractions/vpoxb4i2K6M/i72Kx9v-nYYJ Intellisense!

[khellang]

I agree it looks fugly, but who cares about the signature anyway? As long as you get the extension methods 😄 This problem could probably be solved with your proposed global alias?

[damianh]

Probably not - aliases are only good within a project. AssemblyNeutral delegates would be nice though (if that even makes sense)

[damianh]

In the name of consistency, which I value more, +1 for putting them inside the namespace scope. I do this and live with it.

[grumpydev]

Something is very wrong with this PR.. it's from @khellang and Travis has actually built without errors

[jchannon]

Its Sunday, Travis takes the day off

[khellang]

lol. yeah, crazy! I just popped a 🍺 to celebrate! 😉

[jchannon]

Reckon we could get this in 0.23?

[grumpydev]

Could do.. tbh the most important part is probably obsoleting the old extension method, although I am still not sure what the message should be.

There is value in having the owin stuff in core though I suppose.

[jchannon]

These ones?
https://github.com/NancyFx/Nancy/blob/master/src/Nancy.Owin/AppBuilderExtensions.cs#L23

[damianh]

The suggested builder signature is Action<IDictionary<string, object>, MidFunc> ... which isn't even a proposal yet.

[khellang]

Say what? No one's said this was BuildFunc. I assume you're hinting at the name? Do you have a suggestion?

[damianh]

Right, ignore moi

[damianh]

Keep Nancy.Owin - IAppBuilder and owin.dll will be around for some time yet.

+1 to moving NancyOwinHost to core. Though I'd rename it to NancyMiddleware myself, because Owin Hosts are things like Nowin, HttpListener etc.

[khellang]

And NancyMiddleware was born ✨

[damianh]

After we get some consensus on the using declarations, I'll pull it in! (sooo excited, I pee'd a little)

[grumpydev]

Move em inside :)

[khellang]

Done... mmm, so much better. not 😉

[jchannon]

its not a host?? 😄

[khellang]

Happy now? 😄

[damianh]

wtf travis lol

[grumpydev]

Travis build failed.. be good to see if any @NancyFx/most-valued-minions can restart it.

[grumpydev]

Come on then @NancyFx/most-valued-minions .. who's going to tag this against the milestone and push the magic button? ;)

[jchannon]

I think @damianh has got his finger on the trigger

[damianh]

I am primed.

[phillip-haydon]

We need to roll this back, merge was bad, I didn't approve... Clearly this isn't a team effort...

[damianh]

It happened.

[horsdal]

👯 🍸