Move NancyOwinHost to core. #1544

khellang · 2014-05-25T16:04:43Z

I think it's time we address this and start a discussion on how to structure/package things moving forward, and what better way to do that than with a pull request? 😉

This PR renamesNancyOwinHost to NancyMiddleware and moves it to the core project, (still) under the Nancy.Owin namespace.
The AppBuilderExtensions are left intact in the Nancy.Owin project. API-wise, this is not even a breaking change 👍

I also added extensions for the Action<Func<AppFunc, AppFunc>> approach for adding middleware, used in the new IBuilder.UseOwin extensions. This means that you can now do

public void Configure(IBuilder app)
{
    app.UseOwin(owin => owin.UseNancy());
}

in ASP.NET vNext, without other dependencies than core Nancy 👯

Fixes #1387

jchannon · 2014-05-25T16:43:18Z

src/Nancy/Owin/DelegateExtensions.cs

@@ -0,0 +1,48 @@
+using System;


Put usings under the namspaces declaration human stylecop strike

zOMG! Good job @thecodejunkie isn't watching!

Problem is then you have to declare the Funcs with full names, e.g.

using AppFunc = System.Func<System.Collections.Generic.IDictionary<string, object>, System.Threading.Tasks.Task>

So I think it's worth the tradeoff (what is the tradeoff, exactly? 😝)...

Tbh, the funcs in owin are so much smaller these days I'm not sure I see the point in aliasing them.

And the tradeoff is that putting them inside the namespace scopes them correctly, which can avoid issues with namespace collisions.. on the flip side, putting them outside of the namespace gets you stabbed in the belly by @thecodejunkie, who will grow a Sparta-eque beard just for the occasion.

Swings and roundabouts really.

The latter is what turns up in intellisense though.
On 28 May 2014 09:26, "Kristian Hellang" notifications@github.com wrote:

In src/Nancy/Owin/DelegateExtensions.cs:

@@ -0,0 +1,48 @@
+using System;

the funcs in owin are so much smaller these days I'm not sure I see the
point in aliasing them.

It looks a bit nicer with

UseNancy(this Action)

than

UseNancy(this Action<Func<IDictionary<string, object>, Task>, Func<IDictionary<string, object>, Task>>)

[image: 😉]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1544/files#r13118572
.

https://groups.google.com/d/msg/net-http-abstractions/vpoxb4i2K6M/i72Kx9v-nYYJ Intellisense!

I agree it looks fugly, but who cares about the signature anyway? As long as you get the extension methods 😄 This problem could probably be solved with your proposed global alias?

Probably not - aliases are only good within a project. AssemblyNeutral delegates would be nice though (if that even makes sense)

In the name of consistency, which I value more, +1 for putting them inside the namespace scope. I do this and live with it.

grumpydev · 2014-05-25T16:52:11Z

Something is very wrong with this PR.. it's from @khellang and Travis has actually built without errors

jchannon · 2014-05-25T16:53:14Z

Its Sunday, Travis takes the day off

khellang · 2014-05-25T16:54:57Z

lol. yeah, crazy! I just popped a 🍺 to celebrate! 😉

jchannon · 2014-05-25T16:56:26Z

Reckon we could get this in 0.23?

grumpydev · 2014-05-25T16:58:18Z

Could do.. tbh the most important part is probably obsoleting the old extension method, although I am still not sure what the message should be.

There is value in having the owin stuff in core though I suppose.

jchannon · 2014-05-25T17:01:12Z

These ones?
https://github.com/NancyFx/Nancy/blob/master/src/Nancy.Owin/AppBuilderExtensions.cs#L23

damianh · 2014-05-27T03:43:55Z

src/Nancy/Owin/DelegateExtensions.cs

+        /// <param name="builder">The application builder delegate.</param>
+        /// <param name="action">A configuration builder action.</param>
+        /// <returns>The application builder delegate.</returns>
+        public static Action<MiddlewareFunc> UseNancy(this Action<MiddlewareFunc> builder, Action<NancyOptions> action)


The suggested builder signature is Action<IDictionary<string, object>, MidFunc> ... which isn't even a proposal yet.

Say what? No one's said this was BuildFunc. I assume you're hinting at the name? Do you have a suggestion?

Right, ignore moi

damianh · 2014-05-28T11:06:01Z

Keep Nancy.Owin - IAppBuilder and owin.dll will be around for some time yet.

+1 to moving NancyOwinHost to core. Though I'd rename it to NancyMiddleware myself, because Owin Hosts are things like Nowin, HttpListener etc.

…n etc.)

khellang · 2014-06-10T19:32:24Z

And NancyMiddleware was born ✨

damianh · 2014-06-11T08:48:41Z

After we get some consensus on the using declarations, I'll pull it in! (sooo excited, I pee'd a little)

grumpydev · 2014-06-11T08:53:29Z

Move em inside :)

khellang · 2014-06-11T09:04:10Z

Done... mmm, so much better. not 😉

jchannon · 2014-06-11T09:06:21Z

src/Nancy/Owin/NancyMiddleware.cs

@@ -16,7 +16,7 @@
    /// <summary>
    /// Nancy host for OWIN hosts


its not a host?? 😄

Happy now? 😄

damianh · 2014-06-11T09:11:33Z

wtf travis lol

grumpydev · 2014-06-11T09:11:38Z

Travis build failed.. be good to see if any @NancyFx/most-valued-minions can restart it.

grumpydev · 2014-06-11T09:40:59Z

Come on then @NancyFx/most-valued-minions .. who's going to tag this against the milestone and push the magic button? ;)

jchannon · 2014-06-11T09:45:52Z

I think @damianh has got his finger on the trigger

damianh · 2014-06-11T09:53:43Z

I am primed.

Move NancyOwinHost to core.

phillip-haydon · 2014-06-11T09:57:51Z

We need to roll this back, merge was bad, I didn't approve... Clearly this isn't a team effort...

damianh · 2014-06-11T09:57:52Z

It happened.

horsdal · 2014-06-11T10:01:36Z

👯 🍸

jchannon reviewed May 25, 2014
View reviewed changes

grumpydev added this to the 0.23 milestone May 25, 2014

damianh reviewed May 27, 2014
View reviewed changes

thecodejunkie added the Improvement label May 27, 2014

thecodejunkie modified the milestones: 0.24, 0.23 Jun 4, 2014

khellang added 3 commits June 9, 2014 13:36

Moved NancyOwinHost to Nancy core

fb2bf58

Added extensions for the new delegate-based approach (IBuilder.UseOwi…

d34d95f

…n etc.)

Added missing documentation

5415837

grumpydev modified the milestones: Future, 0.24 Jun 10, 2014

damianh modified the milestones: 1.0Alpha, Future Jun 11, 2014

damianh self-assigned this Jun 11, 2014

jchannon reviewed Jun 11, 2014
View reviewed changes

khellang added 2 commits June 11, 2014 11:39

Renamed NancyOwinHost to NancyMiddleware

1ad9d4d

(re)moved using statements

d197e44

damianh added a commit that referenced this pull request Jun 11, 2014

Merge pull request #1544 from khellang/owin

b871628

Move NancyOwinHost to core.

damianh merged commit b871628 into NancyFx:master Jun 11, 2014

khellang deleted the owin branch June 11, 2014 10:05

grumpydev modified the milestones: 1.0 Alpha, 1.0 Feb 4, 2015

khellang restored the owin branch February 20, 2015 12:08

khellang deleted the owin branch February 20, 2015 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move NancyOwinHost to core. #1544

Move NancyOwinHost to core. #1544

khellang commented May 25, 2014

jchannon May 25, 2014

grumpydev May 25, 2014

khellang May 25, 2014

grumpydev May 25, 2014

grumpydev May 25, 2014

damianh May 28, 2014

damianh May 28, 2014

khellang May 28, 2014

damianh May 28, 2014

damianh Jun 11, 2014

grumpydev commented May 25, 2014

jchannon commented May 25, 2014

khellang commented May 25, 2014

jchannon commented May 25, 2014

grumpydev commented May 25, 2014

jchannon commented May 25, 2014

damianh May 27, 2014

khellang May 27, 2014

damianh Jun 11, 2014

damianh commented May 28, 2014

khellang commented Jun 10, 2014

damianh commented Jun 11, 2014

grumpydev commented Jun 11, 2014

khellang commented Jun 11, 2014

jchannon Jun 11, 2014

khellang Jun 11, 2014

damianh commented Jun 11, 2014

grumpydev commented Jun 11, 2014

grumpydev commented Jun 11, 2014

jchannon commented Jun 11, 2014

damianh commented Jun 11, 2014

phillip-haydon commented Jun 11, 2014

damianh commented Jun 11, 2014

horsdal commented Jun 11, 2014

Move NancyOwinHost to core. #1544

Move NancyOwinHost to core. #1544

Conversation

khellang commented May 25, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grumpydev commented May 25, 2014

jchannon commented May 25, 2014

khellang commented May 25, 2014

jchannon commented May 25, 2014

grumpydev commented May 25, 2014

jchannon commented May 25, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damianh commented May 28, 2014

khellang commented Jun 10, 2014

damianh commented Jun 11, 2014

grumpydev commented Jun 11, 2014

khellang commented Jun 11, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damianh commented Jun 11, 2014

grumpydev commented Jun 11, 2014

grumpydev commented Jun 11, 2014

jchannon commented Jun 11, 2014

damianh commented Jun 11, 2014

phillip-haydon commented Jun 11, 2014

damianh commented Jun 11, 2014

horsdal commented Jun 11, 2014