Fix ignored assemblies. Loads them as late as possible. #638

Closed
wants to merge 6 commits into
from

Projects

None yet

3 participants

Contributor

Loads the assemblies and scans through them when it is asked for it the first time. Updates the ignored assemblies when they're changed.

@grumpydev grumpydev closed this in 2ecc7f7 Jan 17, 2013
Contributor

@grumpydev isn't the adats used to scan for the bootstrapper? Shouldn't it ignore the ignored assemblies when doing that?

Owner

It is, but the ignored assemblies are set in the bootstrapper, and it's only done once on app startup, so I'm not too concerned about that.. as far as I know we've never had an issue where the bootstrapper locator crashed.

Contributor

There has been see issue #629

Owner

That says there's issues with the scanner, but not that the bootstrapper locator crashes.. I've seen scanner issues before, but never had them in the locator.

Owner

Just added a nancy app to an existing mvc site (as mentioned in #629) and it works fine.

Contributor

Allright but the adats does not ignore the ignored assemblies when looking for a bootstrapper.

Owner

I didn't say it did, I said I didn't think that was a problem :-)

I'm actually thinking I might set a default in the static ctor of ADATS that ignores any assembly that doesn't have a nancy reference.. that should speed up the initial scan for the bootstrapper somewhat, and fix your concerns about it blowing up?

Contributor

That would be a smart fix indeed! :) I didn't really have that many concerns about it, but the remaining concerns would definatelly be fixed :P. I didn't know you could see which references an assembly has.

Owner

Quite handy..we added a smilar convention to another place in Nancy.
Basically from an Assembly you can call GetReferencedAssemblies to get info
on them

On Thu, Jan 17, 2013 at 11:14 AM, Albert-Jan Nijburg <
notifications@github.com> wrote:

That would be a smart fix indeed! :) I didn't really have that many
concerns about it, but the remaining concerns would definatelly be fixed
:P. I didn't know you could see which references an assembly has.


Reply to this email directly or view it on GitHubhttps://github.com/NancyFx/Nancy/pull/638#issuecomment-12361706.

Owner

See #916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment