New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.7.6] Invalid URI #37

Closed
reyaz006 opened this Issue Dec 24, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@reyaz006
Copy link

reyaz006 commented Dec 24, 2015

This happens on seemingly random images. Happened >30 times on my batchlist (~4000 members).

2015-12-24 09:33:20,164 DEBUG [   11] - Downloading url: ... ==> ...
2015-12-24 09:33:20,683 ERROR [   12] - filenameFormat={memberId}\{imageId}{page}_{imageTitle}_{serverFilename}
System.UriFormatException: Invalid URI: The Authority/Host could not be parsed.
   in System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   in Nandaka.Common.Util.ExtractFilenameFromUrl(String url, Boolean stripExtension)
   in NijieDownloader.UI.MainWindow.makeFilename(JobDownloadViewModel job, NijieImage image, Int32 currPage, FilenameFormatType type)

Usually followed by

[1003] Failed when renaming

1.0.7.4 and 1.0.7.5 did not have this problem, as far as I can see from the logs.

I think this error forces the app to stop processing current member job leaving it with Error status.

@reyaz006

This comment has been minimized.

Copy link

reyaz006 commented Dec 24, 2015

Tried to do a second run with "Skip if in DB" disabled, got over 1000 errors like this.

@TheDoc69

This comment has been minimized.

Copy link

TheDoc69 commented Dec 26, 2015

I have exactly the same problem. It was working flawlessly before the 1.0.7.6 update.

I tried changing the renaming of files (just {imageId} for example), the folder used by NijieDownloader to save file, http or https mode, etc. but nothing worked.
It happens of more than 80% of the downloads (in my case I use download by tag) and it seems to depend on the image (some images always work, other always fails).

The strange part it that the image is downloaded on the computer, then the error appears and stop the actual tag downloading. So the image which is causing the error is saved on the computer, but no further downloading is possible. In the case of a manga (several pages), in case of error, the first page only is downloaded.
If it can help you here are some nijie ImageID causing the error for me :
151422
151302
151411
And some working images :
151124
151184
151402

EDIT : I don't know if it"s related, but I can't change the language on Nijie website anymore. It stays on Japanese.

@Nandaka Nandaka added the bug label Dec 30, 2015

Nandaka added a commit that referenced this issue Dec 30, 2015

v1.0.7.7
Fix Issue #37: Update image parser.
@reyaz006

This comment has been minimized.

Copy link

reyaz006 commented Dec 30, 2015

v1.0.7.7 fixed this issue. Thank you so much, @Nandaka !

@reyaz006 reyaz006 closed this Dec 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment