/NijieDownloader

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.8] Naming Suggestion #44

Closed
JingJang opened this Issue Mar 31, 2017 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@JingJang @Nandaka
@JingJang

JingJang commented Mar 31, 2017

Two suggestions:

  • {maxPage} seems to add " of ". Can you leave it up to the user to add what they want. So {maxPage} only adds page count with the " of ". It can be easily added in the naming if user wants it.
  • Please consider adding {date} and {date-time}. So you can add "2016-07-30 200944" to the name.

Thanks

Nandaka added a commit that referenced this issue Oct 2, 2017

@Nandaka
Implement #44: remove 'of' from max page
0120e6b

Nandaka added a commit that referenced this issue Oct 2, 2017

@Nandaka
implement #44
fedeb01

@Nandaka Nandaka added the enhancement label Oct 2, 2017

Nandaka added a commit that referenced this issue Oct 2, 2017

@Nandaka
implement #44 
implement #45
483596e

@Nandaka Nandaka closed this Apr 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment