New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-18G toggle? #172

Closed
udw82145 opened this Issue Nov 19, 2016 · 21 comments

Comments

Projects
None yet
4 participants
@udw82145

udw82145 commented Nov 19, 2016

I can respect why r18mode excludes all other "R-18'X'" tags, but could you please add a config mode to download these too?

Alternatively, if you could add an option to download by 'list + tags', then this will solve similar requests.

Much love ❤👊

@Nandaka

This comment has been minimized.

Owner

Nandaka commented Nov 19, 2016

R18mode in config.ini will download only R-18* tagged images.

Check your configuration on the Pixiv website and delete your cookie value in config.ini after updating.
image

@udw82145

This comment has been minimized.

udw82145 commented Nov 20, 2016

So I tested this again with a freshly-made account, a new zip of the latest release, corrected my view settings as above, reloaded my cookie by signing out and in, then double-checking the view settings.
I set r18mode to true, turned off processfromdb and set daylastupdated to 0, and no other changes except login u/p and the new cookie.

I picked at random this(19719856) user to test R-18G tags, and this(237010) user to test R-18? tags.
I tried with both modes 1 (by member id), and 4 (from list.txt).

No matter what I did only R-18 images were downloaded. Even if they were double tagged as R-18 and R-18'X', they downloaded, but only if they had an R-18 tag too.

Feel free to test this yourself, it takes about 20 mins to do everything 👍

@Nandaka

This comment has been minimized.

Owner

Nandaka commented Nov 20, 2016

I set r18mode to true, turned off processfromdb and set daylastupdated to 0, and no other changes except login u/p and the new cookie.
No matter what I did only R-18 images were downloaded.

Off course it will only download the R-18.

Like I said, if you set r18mode=True, it will only download R-18 images (including R-18G).
If you set r18mode=False, it will download all images (including R-18 and R-18G).

If you are using old ui, the main filter is the website settings (e.g. Setting R18 false in website and r18mode=True will return no images).
For whitecube, there is a flag adult_mode=include on the api call which currently always enabled/included.

@udw82145

This comment has been minimized.

udw82145 commented Nov 22, 2016

Except, what I'm saying is that the R-18G images ARE NOT downloaded when r18mode=True

Only the R-18 images, and not the R-18G are being downloaded in this mode. See for yourself.

@Nandaka

This comment has been minimized.

@udw82145

This comment has been minimized.

udw82145 commented Nov 26, 2016

So erm, could you please add an r18gmode, or make an option to download by 'list + tag(s)' ?

@Nandaka Nandaka added the Enhancement label Nov 26, 2016

Nandaka added a commit that referenced this issue Dec 4, 2016

Implement #172
Modify option 4 (download from list.txt) to allow tag input.
@Nandaka

This comment has been minimized.

Owner

Nandaka commented Dec 4, 2016

Modify the option 4. You can set the tag to be downloaded from the member id list.

If no tag given/empty string, it will download all image (older behaviour)

@Nandaka Nandaka closed this Dec 4, 2016

@udw82145

This comment has been minimized.

udw82145 commented Dec 5, 2016

Thanks ever so much!!

@NHOrus

This comment has been minimized.

Contributor

NHOrus commented Dec 6, 2016

And this thing breaks my automation now... Allow that tag to be passed over console?

@Nandaka

This comment has been minimized.

Owner

Nandaka commented Dec 6, 2016

4 - Download from list
(optional: followed by path to list and optional tag)

should be the same: PixivUtil2.py -s 4 -x or PixivUtil2.py -s 4 tag_here -x

https://github.com/Nandaka/PixivUtil2/blob/master/PixivUtil2.py#L1412

@NHOrus

This comment has been minimized.

Contributor

NHOrus commented Dec 6, 2016

Ah. Missed that line.

It just didn't get that it needs to use default if there's no tag... But that's fixed now.

@NHOrus

This comment has been minimized.

Contributor

NHOrus commented Dec 6, 2016

The tag feature interacts with r18mode = true.

@Nandaka

This comment has been minimized.

Owner

Nandaka commented Dec 6, 2016

yep, no changes for that as I'm using it 😄

@NHOrus

This comment has been minimized.

Contributor

NHOrus commented Dec 6, 2016

No, I think it overwrote my pre-set tag? Will test tomorrow and, if doubts remains, elaborate in separate issue.

@Nandaka

This comment has been minimized.

Nandaka added a commit that referenced this issue Dec 6, 2016

@Nandaka

This comment has been minimized.

@reyaz006

This comment has been minimized.

reyaz006 commented Dec 24, 2016

How should I update my command line to make it stop asking for tags? My current line is "-s -4 -x".

@Nandaka

This comment has been minimized.

Owner

Nandaka commented Dec 24, 2016

@reyaz006

This comment has been minimized.

reyaz006 commented Dec 24, 2016

Do you mean it? I haven't found the "tag_here" in the code or readme. Do you mean that I should put some tag there or that any non-valid tag would make it not look for tags? I need the old behavior for now.

@Nandaka

This comment has been minimized.

Owner

Nandaka commented Dec 25, 2016

@reyaz006

This comment has been minimized.

reyaz006 commented Dec 25, 2016

Ok, so it seems "-s 4 list.txt -x" worked. Thanks.

Nandaka added a commit that referenced this issue Mar 4, 2017

Implement #172
Modify option 4 (download from list.txt) to allow tag input.

Nandaka added a commit that referenced this issue Mar 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment