New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixiv Util crashes if network temporarily unavailable while scanning user. #237

Closed
awiebe opened this Issue Jun 30, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@awiebe
Contributor

awiebe commented Jun 30, 2017

My internet went out temporarily, and rather than failing gracefully after 4 retries, pixiv util crashed horribly. It seems to have proceeded even though it failed to get some data, and then crashed because of a null reference. I would recommend that the default behaviour here be to retry indefinitely, or wait for user input to retry again.


Member ID ([redacted]): 9005 'Failed to get page: ' 
Traceback (most recent call last):
  File "PixivUtil2.py", line 354, in process_member
    if list_page is not None:
UnboundLocalError: local variable 'list_page' referenced before assignment
Error at process_member(): (<type 'exceptions.UnboundLocalError'>, UnboundLocalError("local variable 'list_page' referenced before assignment",), <traceback object at 0x10bfa7dd0>) 
Cannot dump page for member_id:[redacted]
Error at process_bookmark(): (<type 'exceptions.UnboundLocalError'>, UnboundLocalError("local variable 'list_page' referenced before assignment",), <traceback object at 0x10bfa7e18>)
Traceback (most recent call last):
  File "PixivUtil2.py", line 1876, in main
    np_is_valid, op_is_valid, selection = main_loop(ewd, mode, op_is_valid, selection, np_is_valid, args)
  File "PixivUtil2.py", line 1665, in main_loop
    menu_download_from_online_user_bookmark(mode, op_is_valid, args)
  File "PixivUtil2.py", line 1468, in menu_download_from_online_user_bookmark
    process_bookmark(mode, hide, start_page, end_page)
  File "PixivUtil2.py", line 1031, in process_bookmark
    process_member(mode, item.memberId, item.path)
  File "PixivUtil2.py", line 508, in process_member
    if list_page is not None:
UnboundLocalError: local variable 'list_page' referenced before assignment
press enter to exit.

@Nandaka

This comment has been minimized.

Owner

Nandaka commented Jul 5, 2017

I'll fix the unbound error, but most likely it will just go back to main page for the behaviour.

Nandaka added a commit that referenced this issue Jul 5, 2017

@Nandaka Nandaka closed this Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment