From b8ddcfab3c7ec162063a2614c6492dd77ef6e83e Mon Sep 17 00:00:00 2001 From: Hassan_Wari Date: Fri, 1 Mar 2024 12:26:14 +0300 Subject: [PATCH 1/3] Gong API changes --- docs-v2/integrations/all/gong.mdx | 2 ++ packages/shared/providers.yaml | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs-v2/integrations/all/gong.mdx b/docs-v2/integrations/all/gong.mdx index 58533bdc7b..44e6088b5d 100644 --- a/docs-v2/integrations/all/gong.mdx +++ b/docs-v2/integrations/all/gong.mdx @@ -24,6 +24,7 @@ Gong offers both Basic auth (API key) and OAuth as authentication. Nango impleme - [How to find API credentials (for end-users)](https://help.gong.io/hc/en-us/articles/360042449451-Receive-access-to-the-API) - [Request a developer account to create an OAuth app](https://app.gong.io/welcome/developer/sign-up) - [API Docs](https://app.gong.io/settings/api/documentation#overview) +- [Oauth-related docs](https://help.gong.io/hc/en-us/articles/13944551222157-Create-an-app-for-Gong) Need help getting started? Get help in the [community](https://nango.dev/slack). @@ -32,5 +33,6 @@ Gong offers both Basic auth (API key) and OAuth as authentication. Nango impleme - End users can generate API keys [on the Gong API page](https://app.gong.io/company/api). They must have the "technical administrator" user role to do this. - Gong uses BASIC auth for their API, but doesn't call them username and password: `Access Key` is the username in Nango and `Access Key Secret` is the password in Nango. - [Gong rate-limits](https://app.gong.io/settings/api/documentation#overview) are per second and a total of 10k requests a day. +- Gong-oauth uses `api_base_url_for_customer`, which varies for each customer, as its `base_url` for proxy requests. This parameter is returned in the response of `generate-customer-token`. Add Getting Started links and Gotchas by [editing this page](https://github.com/nangohq/nango/tree/master/docs-v2/integrations/all/gong.mdx) diff --git a/packages/shared/providers.yaml b/packages/shared/providers.yaml index 3fbd9161fa..dd9983712f 100644 --- a/packages/shared/providers.yaml +++ b/packages/shared/providers.yaml @@ -733,6 +733,8 @@ gong-oauth: auth_mode: OAUTH2 authorization_url: https://app.gong.io/oauth2/authorize token_url: https://app.gong.io/oauth2/generate-customer-token + token_response_metadata: + - api_base_url_for_customer authorization_params: response_type: code access_type: offline @@ -743,7 +745,7 @@ gong-oauth: disable_pkce: true token_request_auth_method: basic proxy: - base_url: https://api.gong.io + base_url: ${connectionConfig.api_base_url_for_customer} docs: https://docs.nango.dev/integrations/all/gong google: auth_mode: OAUTH2 From 43841d502d7ea4b1d5dfa767fa1d6d911e976e7e Mon Sep 17 00:00:00 2001 From: Hassan_Wari Date: Tue, 19 Mar 2024 00:26:29 +0300 Subject: [PATCH 2/3] review --- packages/shared/providers.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shared/providers.yaml b/packages/shared/providers.yaml index fa73789ea7..be12f8f308 100644 --- a/packages/shared/providers.yaml +++ b/packages/shared/providers.yaml @@ -755,7 +755,7 @@ gong-oauth: disable_pkce: true token_request_auth_method: basic proxy: - base_url: ${connectionConfig.api_base_url_for_customer} + base_url: ${connectionConfig.api_base_url_for_customer} || https://api.gong.io docs: https://docs.nango.dev/integrations/all/gong google: auth_mode: OAUTH2 From a7580f44abc9a173b10c12bb16fe0a7d605437b8 Mon Sep 17 00:00:00 2001 From: Hassan_Wari Date: Tue, 28 May 2024 11:11:20 +0300 Subject: [PATCH 3/3] revert proxy base_url --- packages/shared/providers.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shared/providers.yaml b/packages/shared/providers.yaml index be12f8f308..fa73789ea7 100644 --- a/packages/shared/providers.yaml +++ b/packages/shared/providers.yaml @@ -755,7 +755,7 @@ gong-oauth: disable_pkce: true token_request_auth_method: basic proxy: - base_url: ${connectionConfig.api_base_url_for_customer} || https://api.gong.io + base_url: ${connectionConfig.api_base_url_for_customer} docs: https://docs.nango.dev/integrations/all/gong google: auth_mode: OAUTH2