New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ads] m.timesofinfia.com #57

Closed
ghajini opened this Issue Apr 8, 2018 · 24 comments

Comments

Projects
None yet
3 participants
@ghajini

ghajini commented Apr 8, 2018

@jspenguin2017
The reason I posted here becoz I see unresolved issues for this in uassets

https://github.com/uBlockOrigin/uAssets/issues/247

URLs where this issue occurs

https://m.timesofindia.com

https://m.timesofindia.com/sports/cricket/ipl/top-stories/ipl-2018-kolkata-knight-riders-beat-royal-challengers-bangalore-by-four-wickets/articleshow/63672323.cms

Screenshots (Required) &issue descriptions

I see ads by colombia ad network on toi homepage

  1. as I click on ad on homepage

http://prntscr.com/j2ltmx
It's logger output
http://prntscr.com/j2lu6x
I see in logger 1stly taboola.com is whitelisted (found in ublock unbreak list) hence it pass to adservers adcanopus

Why taboola is whitelisted globally in ublock origin as it redirects to ad networks
Depending on which ad it display it passes to revolving adservers
http://prntscr.com/j2lyfm

  1. on individual stories
    I see 'recommended by coloumbia' or 'from around the web' ads

Screenshot of console (Required, press F12 to open the console)

Describe the issue -

Ads by colombia everywhere on page

Reproduction Steps (Optional if trivial)

Just go to any invidual stories and see ads

Anything else you believe to be useful (Optional):

Environment (Required)

  • Operating System and Version: Android 7.1.2
  • Browser and Version: Firefox for Android 59.0.2
  • Ublock origin 1.15.24

Your filter lists (Required)

default settings+adguard mobile filters

Your custom filters (Required if you have any)

@jspenguin2017 jspenguin2017 changed the title from m.timesofinfia.com coloumbia ads to [Ads] m.timesofinfia.com Apr 8, 2018

jspenguin2017 added a commit to jspenguin2017/uBlockProtector that referenced this issue Apr 8, 2018

@ghajini

This comment has been minimized.

ghajini commented Apr 8, 2018

How can I use it on firefox Android .
Can you provide nano defender for Firefox Android(as I know defender is not available for firefox)

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 8, 2018

You'll need Nano Defender. @krystian3w
cc @okiehsch

jspenguin2017 added a commit to jspenguin2017/uBlockProtector that referenced this issue Apr 8, 2018

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 8, 2018

Hold on, it doesn't quite work... The mobile site is structured differently.

@ghajini

This comment has been minimized.

ghajini commented Apr 8, 2018

Correct ,structured differently.... sometimes filters don't work for m.timesofindia.com if you create one for timesofindia.com

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 8, 2018

"From around the web" should be blocked too, right?

@ghajini

This comment has been minimized.

ghajini commented Apr 8, 2018

Yes ....it would be nice if you self sign nano defender version for Firefox & release/autoupdate (like gorhill doing)

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 8, 2018

Seems that m.timesofindia.com##.adsinview would work.
I also have a backup plan.
I'll wait for @okiehsch

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 8, 2018

The desktop site is not fixed in uBO.
The script rule in Nano Defender seems to still work though.

@ghajini

This comment has been minimized.

ghajini commented Apr 8, 2018

Still ad on homepage after m.timesofindia.com##.adsinview
http://prntscr.com/j2mpcf

jspenguin2017 added a commit that referenced this issue Apr 8, 2018

jspenguin2017 added a commit to jspenguin2017/uBlockProtector that referenced this issue Apr 8, 2018

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 8, 2018

Eh, I guess not getting away with script rule then.

@jspenguin2017 jspenguin2017 removed the fixed label Apr 8, 2018

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 8, 2018

Alright, I'll call this fixed, unless @okiehsch wants to add the partial fix.

@ghajini

This comment has been minimized.

ghajini commented Apr 8, 2018

IAM on ubo only,Firefox Android. NOT using nano defender now

@okiehsch

This comment has been minimized.

okiehsch commented Apr 8, 2018

I have reopended uBlockOrigin/uAssets/issues/247, and linked to this issue, I am short of time, so no fix from me for now.

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 8, 2018

I marked the partial fix as Pending Synchronization, let me know if it lands in uAssets. I don't see how would you fix the other part with plain filters though.

@ghajini

This comment has been minimized.

ghajini commented Apr 8, 2018

Would you make userscript ver of your solution found in nano defender?

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 8, 2018

No, I have better things to do.

@okiehsch

This comment has been minimized.

okiehsch commented Apr 8, 2018

@jspenguin2017 will do, I already have a working fix for #56, I will add that one later today.

@ghajini

This comment has been minimized.

ghajini commented Apr 8, 2018

Ok confine to using ubo only, anything other is waste

okiehsch added a commit to uBlockOrigin/uAssets that referenced this issue Apr 11, 2018

@okiehsch

This comment has been minimized.

okiehsch commented Apr 11, 2018

Added your fix.

@ghajini

This comment has been minimized.

ghajini commented Apr 11, 2018

That's partial fix

@okiehsch

This comment has been minimized.

okiehsch commented Apr 11, 2018

Well, that's why my commit is called "partially address NanoAdblocker/NanoFilters#57 as suggested".

@jspenguin2017

This comment has been minimized.

Member

jspenguin2017 commented Apr 11, 2018

@okiehsch Cool, since you are here...
Missed ads on https://btcmanager.com/the-fiery-asic-debate-engulfs-the-bitcoin-and-monero-communities/
Rule:

btcmanager.com##.wpbanners-banner
btcmanager.com##.advert

jspenguin2017 added a commit that referenced this issue Apr 11, 2018

@okiehsch

This comment has been minimized.

okiehsch commented Apr 11, 2018

Well, that should really be part of EasyList in my opinion.
I try to be consistent and only add filters for issues that require extended filter syntax, you may disagree and can open such an issue at uAssets.

Edit: I added m.timesofindia.com##.adsinview because there are already filters for that site in uBO-filters, so it would be nonsensical to not add new ones only because they do not require extended filter syntax.

@okiehsch

This comment has been minimized.

okiehsch commented Apr 11, 2018

I also will add all kind of filters for anti-adblock issues, because EasyList does not include such filters for
"legal" reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment