Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example starts and terminates directly #266

Closed
dagnelies opened this issue Dec 9, 2015 · 4 comments
Closed

example starts and terminates directly #266

dagnelies opened this issue Dec 9, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@dagnelies
Copy link

@dagnelies dagnelies commented Dec 9, 2015

Hi,

I just picked the example provided on the front page, and it correctly shows:
Running! Point your browers to http://localhost:8080/
But it terminates right after.

Anything I'm doing wrong?

@jpeyper
Copy link

@jpeyper jpeyper commented Dec 9, 2015

I had this same issue, I changed the start command to

server.start(NanoHTTPD.SOCKET_READ_TIMEOUT, false);

so it is not running in a daemon thread and it now stays running.

@dagnelies
Copy link
Author

@dagnelies dagnelies commented Dec 10, 2015

ok, thanks. It'd be nice to make this the default.

I'll leave the ticket open for now if you don't mind, it might help others.

@jpeyper
Copy link

@jpeyper jpeyper commented Dec 10, 2015

Yes, or update the docs on the main page.

If you get to it, the ssl example is also out of date. The makeSecure method takes a second parameters (use null if you want the default sslProtocols).

ritchieGitHub added a commit that referenced this issue Dec 18, 2015
@ritchieGitHub ritchieGitHub added this to the 2.3.0 milestone Dec 18, 2015
@ritchieGitHub ritchieGitHub self-assigned this Dec 18, 2015
@ritchieGitHub
Copy link
Member

@ritchieGitHub ritchieGitHub commented Dec 18, 2015

documentation ist updated, thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.