Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Starting v3.0 :D #357
This is my first piece of work for 3.0
Since this will introduce a lot of breaking changes I propose we freeze the code before accepting this, and resume normal activity once I finish it, probably in 2 weeks from now.
Meanwhile PRs will potentially break everything.
I'd also like to bring to your attention that I expect @ritchieGitHub and/or @elonen to have a good look at this in order to revise and accept it, as I'm not going to be so cheeky as to accept this one with the potential to break every single thing ever :p
Also, we should probably drop the websockets module and merge its code into the core module since in a while it will start to make a lot more sense to be there. All packages have been appropriately named so that both fit together nicely, but since this messes with external tools I'm not going to do it myself.
@ritchieGitHub this is being a bit confusing to figure out, can you lend me a hand when you have the time? I'm delivering my course's (CS / IT Engineering) final project this week so I'm rather busy and I've had a hard time figuring what the hell is wrong by myself so far.
Travis / JUnit complain about being unable to reach class definitions, but they are there. Do we need to declare any kind of inter-module dependencies in order for this to work on Travis?
added a commit
this pull request
Sep 9, 2016
the problems are fixed, checked in the changes in a branch:
The problems where caused by the different package names, probably your IDE did not refactor them correctly. Specially the service loader config files. nor the build works