Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed remoteHostName from HTTPSession: it can take too long time to… #546

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@wing9405
Copy link

commented Jul 2, 2019

… figure out via DNS

hyunik.na
@coveralls

This comment has been minimized.

Copy link

commented Jul 2, 2019

Coverage Status

Coverage decreased (-0.02%) to 85.166% when pulling cd37235 on wing9405:master into b04a342 on NanoHttpd:master.

@wing9405

This comment has been minimized.

Copy link
Author

commented Jul 3, 2019

Figuring out a host name sometimes took several seconds and caused a HTTP request timeout in my environment. I guess the situation will be the same for many others.
And, I doubt that the host name is really commonly used and required. I think It should be obtained in the 'serve(IHTTPSession session)' method, if required, in a not time-consuming way.

@LordFokas

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

I actually had a JIT fix for this in v3.0
Since I can't seem to get that going any time soon, I'll accept this.

@LordFokas LordFokas merged commit efb2ebf into NanoHttpd:master Jul 3, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 85.166%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.