Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new checks #1

Merged
merged 7 commits into from Jan 29, 2021
Merged

Add new checks #1

merged 7 commits into from Jan 29, 2021

Conversation

rverchere
Copy link
Contributor

  • Rename grid usage to h-a usage (based on OID informations)
  • Add service check
  • Add DNS View check
  • Add SWAP check

@Napsty
Copy link
Owner

Napsty commented Dec 9, 2020

Hello @rverchere
Thanks for the PR!
Sorry for this huge delay. Github never notified me on this PR :-/

As I don't have an Infoblox appliance anymore, I cannot test this PR. Can you show the output of the plugin with your modifications please? You can of course obfuscate sensitive data.

@rverchere
Copy link
Contributor Author

Hi @Napsty , here are the output:

#./check_infoblox.sh -H 192.168.1.123 -C mycommunity -V 2c  -t swap -w 80 -c 90
SWAP OK - Usage at 0%|ibloxswap=0%;80;90;;
# ./check_infoblox.sh -H 192.168.1.123 -C mycommunity -V 2c -t dnsview -a "Private View"
DNS View Private View exists
# echo $?
0
# ./check_infoblox.sh -H 192.168.1.123 -C mycommunity -V 2c -t dnsview -a "Private View" -n
DNS View Private View exists
# echo $?
2
# ./check_infoblox.sh -H 192.168.1.123 -C mycommunity -V 2c -t service -a dns
"DNS Service is working"

Thanks!

@Napsty
Copy link
Owner

Napsty commented Dec 10, 2020

OK just one minor comment, otherwise lgtm.

The service check requires an additional argument. It would be helpful to show this in the "help" output which input is expected. For example dns, ntp, dhcp, ..., Could you please add the this information somewhere in the help output?

Signed-off-by: Rémi VERCHERE <remi.verchere@axians.com>
@rverchere
Copy link
Contributor Author

The service check requires an additional argument. It would be helpful to show this in the "help" output which input is expected. For example dns, ntp, dhcp, ..., Could you please add the this information somewhere in the help output?

Done, also added/corrected ouput, adding OK, WARNING & co in stdout.

@Napsty Napsty merged commit b58bd5d into Napsty:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants