New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shellcheck #6

Merged
merged 18 commits into from Dec 4, 2018

Conversation

Projects
None yet
2 participants
@BarbUk
Contributor

BarbUk commented Dec 28, 2017

Fix several shellcheck warning and error

@BarbUk

This comment has been minimized.

Contributor

BarbUk commented Dec 28, 2017

The resulting script was tested on debian 9 with lxc 2

Show resolved Hide resolved check_lxc.sh
@Napsty

This comment has been minimized.

Owner

Napsty commented Dec 3, 2018

Thanks @BarbUk
These are a lot of speed improvements, learning a lot here ;-)
Would you be so kind and adapt the PR for the latest release (currently 0.6.2) to be able to merge?
Thx

@Napsty Napsty self-assigned this Dec 3, 2018

@Napsty Napsty added the enhancement label Dec 3, 2018

BarbUk added some commits Dec 3, 2018

@BarbUk

This comment has been minimized.

Contributor

BarbUk commented Dec 3, 2018

Hey, thanks for the feedback.
I've merged the new version into my branch and resolved the conflicts.

I've added some new fix from shellcheck.
The resulting script has been tested against lxc 2.0.7-2 on a debian stretch.

@Napsty

This comment has been minimized.

Owner

Napsty commented Dec 4, 2018

Successfully tested on

  • Ubuntu 14.04 with LXC 1.0.8
  • Ubuntu 18.04 with LXC 3.0.2 (however: #9 )

Thx for the contribution!

@Napsty Napsty merged commit 7a4e59a into Napsty:master Dec 4, 2018

@BarbUk BarbUk deleted the BarbUk:fix/shellcheck branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment