Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-router] allow v0.3 #248

Merged
merged 1 commit into from May 16, 2016
Merged

Conversation

aitboudad
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 95a7afc on aitboudad:patch-1 into c542e97 on Narzerus:master.

@@ -41,7 +41,7 @@
},
"peerDependencies": {
"angular": "^1.4.8",
"angular-ui-router": "^0.2.11"
"angular-ui-router": "^0.2.11, ^0.3.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be "^0.x" as I don't think comas are acceptable? Or am I wrong?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "0.2.x || 0.3.x"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@masterspambot
Copy link
Collaborator

Thanks for noticing that!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 774171d on aitboudad:patch-1 into c542e97 on Narzerus:master.

masterspambot added a commit that referenced this pull request May 16, 2016
fix: #249 - Module is not defined
chore: Bump version to 3.1.1
@masterspambot masterspambot merged commit 207104a into RafaelVidaurre:master May 16, 2016
@aitboudad aitboudad deleted the patch-1 branch May 16, 2016 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants