Adding heat transfer solve and velocity profile inputs#73
Merged
arswalid merged 158 commits intoFeb 27, 2025
Conversation
…(a float) over which vel goes from 0->u_ref
…ow a float that defines ramp up window
…olic+coeff+ramp_up_window for flag
… with that in add_air_temperature
…ange to constant temperature
Collaborator
Author
This was referenced Dec 11, 2024
Collaborator
Author
…ionary to store lchar too
…, needs new truth after mesh change
…es, don't compare against True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
input/heated_panels2d.yamlruns on the HPC andinput/test_heatedpanels2d.yamlruns locally.Why
This feature enables the study of thermal effects of the presence of PV panels, such as how panels heat the surrounding air and how ground temperature (via atmospheric stability) affects the flow through a solar farm. This is the first step to studying the effect of the flow in a solar farm on convective cooling of a PV panel.
Code Changes
For task 1 (heat transfer solve):
panels2das the baseline example and adapted it to include temperature via heated panelsupstream/syncas base branch for the code changesFor task 2 (velocity profile input):
While implementing these changes, also fixed pre-existing bugs:
panels2dmoduleRemaining Open Tasks
Git issues have been opened to:
u < 1.0m/s) (Issue Simulations explode at the outflow when thermal_analysis is on #76)input/folder run without errors (Issue Create a test that ensures all files in input folder run without errors #74)Related Issues and PRs
This PR includes the changes from PR #60, which will be closed without merging.
This PR supersedes PR #52, which will be closed without merging.