Bug fixes #98
Conversation
from Dev on NREL repo to my fork
…to structural xdmf file
…ctly to res, add internal stress and trial/test functions on tensor function space
… never explicitly updated, only the form is updated
pull Ethan changes for structure files
|
I tried running with |
| mesh_only: False | ||
| # input_mesh_dir: output/panels3d/mesh | ||
| structural_analysis: True | ||
| structural_analysis: False |
There was a problem hiding this comment.
What's the reason for turning off the structural solve for panels3d?
There was a problem hiding this comment.
no specific reason, probably forgot it, ill change structure to true
| hmin_local = np.inf | ||
|
|
||
| # collect the minimum hmin from all processes | ||
| print(hmin_local) |
There was a problem hiding this comment.
Should we remove these print statements when merging into dev? Or add the flag if verbose_flag == True: before printing?
| local_def_max = np.amax(np.sum(u_reshaped**2, axis=1)) | ||
| else: | ||
| local_def_max = -np.inf # So it doesn't interfere in max | ||
| print( |
There was a problem hiding this comment.
Same comment as above - do we want to remove these print statements or move them into a verbose_flag == True block?
There was a problem hiding this comment.
I agree, we need to set most prints to show up ally if verbose, We need to determine which prints should always remain and which should be verbose only.
you need to define numpy_pt_total_array in your domain creation file |
This error will be addressed in PR #89 |
3 participants
This PR also includes #88 and #96 (comment)
Items fixed:
input files fixed
list still in progress
I need reviews as the PR progresses