ARM: Correct Sleigh constructor for VCVT{R}<c>.S32.F32 #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bits 23-27 are defined with a bit encoding of 0b11101, not 0b11011 (See section F6.1.60 within the ARMv8 reference manual or section A8.8.306 within the ARMv7 reference manual). This makes conversions from floating-point registers to signed values disassemble/decompile more properly and not as generic CDP instructions, making decompilation a little more informative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bits 23-27 are defined with a bit encoding of
0b11101, not0b11011(See section F6.1.60 within the ARMv8 reference manual or section A8.8.306 within the ARMv7 reference manual).This makes conversions from floating-point registers to signed values disassemble/decompile more properly and not as generic CDP instructions, making decompilation a little more informative.