Fixed issues with dyld_shared_cache parsing #2560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First issue fixed was a simple null deref. The other issue is the dylib's load commands in the dyld_shared_cache should be absolute from zero not relative from the start of the dylib's mach header. When done incorrectly this causes a read past the end of file.
|
Merged for release in 9.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First issue fixed was a simple null deref. The other issue is the
dylib's load commands in the dyld_shared_cache should be absolute from
zero not relative from the start of the dylib's mach header. When done
incorrectly this causes a read past the end of file.