Decompiler: Add support for INT_REM in jumptable recovery.#6070
Closed
LukeSerne wants to merge 3 commits into
Closed
Decompiler: Add support for INT_REM in jumptable recovery.#6070LukeSerne wants to merge 3 commits into
LukeSerne wants to merge 3 commits into
Conversation
mumbel
reviewed
Dec 30, 2023
LukeSerne
force-pushed
the
decomp-jumptable-recovery-add-int-rem
branch
from
7da9f4f to
1cae319
Compare
ryanmkurtz
added
Feature: Decompiler
Status: Triage
|
This won't help with my case... sniff |
Contributor
Author
|
@Nemoumbra could you share the bytes / instructions corresponding to the function containing that segment? I tried reproducing this, but even when the assembly clearly did a comparison of the switch variable before the lookup, the decompiler still properly decompiled the switch. It might be that there is more in your function that contributes to the problem. Either way, I think it's better to continue discussion in issue #2628. @ryanmkurtz is there anything I can do to help get this PR out of triage, and closer to being merged? |
|
@LukeSerne I have no clue which program I was studying back then.😭 |
jobermayr
reviewed
Jun 16, 2026
This commit adds INT_REM handling to JumpBasic, which allows switch statements depending on expressions like "x % 10" to be properly recovered. Previously, a warning was emitted about there being "too many branches".
This commit adds a fallback to use the non-zero mask to determine the maximum value a varnode can take. It also slightly improves the case where a varnode is defined by a MULTIEQUAL by recursively calling the getMaxValue function.
By keeping track of how deep in the recursive chain we are, we can avoid infinite recursion.
LukeSerne
force-pushed
the
decomp-jumptable-recovery-add-int-rem
branch
from
632a0d0 to
6572c4a
Compare
ryanmkurtz
added
Status: Internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds
INT_REMhandling to theJumpBasicclass, which allows switch statements depending on expressions likex % 10to be properly recovered. Previously, a warning was emitted about there being "too many branches". This slightly improves the third problem mentioned in #2628 (comment).Screenshots
These screenshots show the
mainfunction of theswitchexample fromGhidraDocs/GhidraClass/Advanced/Examplesafter auto-analysis.Before applying the patch
After applying the patch
