Merge/migrate to bifrost #7
Conversation
…igrate-to-bifrost
this way we don't have to add context conditional - more deterministic
gwleuverink
force-pushed
the
merge/migrate-to-bifrost
branch
from
943f58d to
c436565
Compare
|
@SRWieZ I've update your original PR to fit within the new structure. Also made a small change in how the ManagesEnvFile trait is used. Thought it is a bit more deterministic to always use it through the builder class. What do you think? |
|
The static analysis workflow is fixed in #6 If we merge that one first & then update upstream on this branch everything should be green |
|
|
||
| private function prepareBundlePath(): string | ||
| { | ||
| $buildDir = base_path('build'); |
There was a problem hiding this comment.
@SRWieZ Something to consider:
The dist directory has moved to nativephp/electron/dist. Does it make sense to download the bundle inside there too? maybe in nativephp/electron/bundle?
There was a problem hiding this comment.
if nativephp/electron/dist is where Electron binaries are after native:build, then it's good, it's easier if I only have one directory to check for Bifrost builds.
I don't know if I need the builder class in that case, it's just one command that helps you log in to Bifrost in the end. Otherwise, PR looks good, you can merge it, and I will try it and fix it later. |
|
Sweet. I'll merge it 👌🏻 |
Fixed all conflicts with base branch in PR #3