Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are iOS modal animations disabled by default? Can we pass an option to enable it? #1129

Closed
rclai opened this issue Nov 20, 2015 · 5 comments
Assignees
Milestone

Comments

@rclai
Copy link
Contributor

rclai commented Nov 20, 2015

parent.ios.presentViewControllerAnimatedCompletion(this._ios, false, function completion() {

parent._ios.dismissModalViewControllerAnimated(false);

@N3ll N3ll added this to the 1.6 (Under Review) milestone Nov 23, 2015
@enchev
Copy link
Contributor

enchev commented Feb 12, 2016

Will be animated in iOS 9 and above!

@enchev enchev closed this as completed Feb 12, 2016
@toddanglin
Copy link

Shouldn't there be an overload for showModal that accepts a NavigationEntry?

This would allow you to control the modal animation and possibly use a page factory to generate the modal view page. Does this make sense? Or am I crazy? :)

@enchev
Copy link
Contributor

enchev commented Feb 22, 2016

Hey @toddanglin,

We believe that our modal pages should not be part of the navigation stack - you cannot navigate to a modal page.

@toddanglin
Copy link

That makes sense.

I was looking at it from the view of providing a way to specify the transitions (iOS/Android/Default) when showing a modal view, and possibly to provide the ability to dynamically generate a modal view (the create function). Is there a better/different way to do this with modals?

@lock
Copy link

lock bot commented Aug 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants