Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs-ios): unable to return to tab after tab with nested frame visited #7574

Merged
merged 26 commits into from Jul 25, 2019

Conversation

ADjenkov
Copy link
Contributor

@ADjenkov ADjenkov commented Jul 24, 2019

Postpone load/unload until UIPageViewController animation between 'pages' completes
Note: If nested frame available inside TabContentItem, it will be shown just after animation completes.

Includes rebase of mdonev/tabs-bottom-nav-e2e branch

Fix #7564

@ADjenkov ADjenkov self-assigned this Jul 24, 2019
@cla-bot cla-bot bot added the cla: yes label Jul 24, 2019
@ADjenkov
Copy link
Contributor Author

test --ignore branch-nested-frame-navigation#mdonev/tabs-bottom-nav-e2e api23 ios12 uitests

@SvetoslavTsenov SvetoslavTsenov merged commit 490cab0 into release Jul 25, 2019
@SvetoslavTsenov SvetoslavTsenov deleted the djenkov/preload-ios-tabs branch July 25, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants