Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): ActionBar style wrong after cancelled swipe back navigation #8252

Merged
merged 4 commits into from Jan 16, 2020

Conversation

vakrilov
Copy link
Contributor

PR Checklist

What is the current behavior?

If swipe back navigation is cancelled - the current page ActionBar gets the style from the previous page in the nav-stack (the one that we were swiping back to).

What is the new behavior?

If the swipe back navigation is cancelled - the current style of the ActionBar is preserved.

Fixes: #7430

@cla-bot cla-bot bot added the cla: yes label Jan 15, 2020
@vakrilov vakrilov marked this pull request as ready for review January 15, 2020 20:41
@vakrilov
Copy link
Contributor Author

@dtopuzov e2e test needed and can be implemented in the e2e/ui-test-app.
Here are the steps:

  1. Go to actBG page
  2. Action bar is green
  3. Click the go to cleared page
  4. Action bar is white again
  5. Start swipe-back navigation form the left of the screen, but then cancel
  6. Validate: The navigations stays on the same page and the action bar remains white (without the fix it turns green as it wrongly takes the styles from the previous page)

nativescript-core/ui/page/page.ios.ts Outdated Show resolved Hide resolved
@dtopuzov
Copy link
Contributor

test --ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swipe back navigation overrides ActionBar styles (iOS)
3 participants