Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modal] ns-dark not applied to top element #8374

Closed
farfromrefug opened this issue Feb 24, 2020 · 3 comments
Closed

[modal] ns-dark not applied to top element #8374

farfromrefug opened this issue Feb 24, 2020 · 3 comments
Labels

Comments

@farfromrefug
Copy link
Collaborator

I am using latest of everything

If you run the attached example:

  • click the button => opened page is not themed but child label is
  • change the code to open modal modalFrame/modalFrame
  • click the button => opened page is themed but child label is
    NSPlayground 2.zip

I think the issue is that the top/root view opened in modal is not applied ns-dark.

I also see that behavior in my nativescript-material-bottomsheet and nativescript-material-dialogs when i show custom view inside dialog or bottom sheet.
https://github.com/Akylas/nativescript-material-components/blob/2ed3d870bdce10e66fa2bcda4d936da499690f39/src/bottomsheet/bottomsheet-common.ts#L134
BTW it happens on both platforms

@NickIliev NickIliev added the css label Feb 24, 2020
@NavruzbekNoraliev
Copy link

same issue, bottom sheet doesn't read ns dark styles

@Bezlepkin
Copy link

Same issue in modalDialog....

@rigor789
Copy link
Member

Fixed in #10201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants