chore(tslint): fix tslint config & errors #5747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ghost
added
the
sis0k0
reviewed
Apr 26, 2018
build/tslint.json
Outdated
| "check-open-brace", | ||
| "check-catch", | ||
| "check-else", | ||
| "check-whitespace" | ||
| ], | ||
| "quotemark": [false, "double"], | ||
| "quotemark": [ | ||
| false, |
There was a problem hiding this comment.
Shouldn't this be true if we want to force double quotes?
There was a problem hiding this comment.
@sis0k0 I did not disable this rule originally but it is now enabled and the errors fixed :).
sis0k0
approved these changes
Apr 26, 2018
|
@sis0k0 enabled additionally |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tslint.json syntax for some rules and the tslint errors uncovered by that fix.