Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): IllegalStateException with tabview&nested frames #6495

Merged
merged 3 commits into from Nov 5, 2018

Conversation

Projects
None yet
4 participants
@manoldonev
Copy link
Contributor

manoldonev commented Nov 2, 2018

Fixes: #6490
Related to: #6339
Related to: #6421

This fix was originally applied with #6339 but was later reworked with #6421 (basically the part in frame.android.ts where disposing the fragments is performed after super.unloaded(...) logic).

The original fix did not work properly when called in onDestroyView(...) as it essentially removed the fragment view too early hence breaking exit transition. I actually tested onDestroy(...) then as well but due to a different bug addressed with #6421 and #6489 (essentially we need to cache and restore animators because of the simulated first navigation) onDestroyView(...) and onDestroy(...) were called at the same time (now onDestroy(...) is called after the actual exit transition is finished which means we can use it to detach the native view from its parent).

@manoldonev manoldonev self-assigned this Nov 2, 2018

@wafflebot wafflebot bot added the in progress label Nov 2, 2018

@manoldonev

This comment has been minimized.

Copy link
Contributor Author

manoldonev commented Nov 2, 2018

test --ignore uitests_android ngapps_android api19 api23 api28

@manoldonev manoldonev requested review from ADjenkov , vakrilov and MartoYankov Nov 2, 2018

@ns-bot ns-bot added the cla: yes label Nov 2, 2018

@manoldonev

This comment has been minimized.

Copy link
Contributor Author

manoldonev commented Nov 2, 2018

test --ignore uitests_android ngapps_android api19 api23 api28

@manoldonev manoldonev force-pushed the mdonev/child-already-has-a-parent-fix branch from 402414f to cf59ca9 Nov 5, 2018

@SvetoslavTsenov

This comment has been minimized.

Copy link
Contributor

SvetoslavTsenov commented Nov 5, 2018

test ngapps#svetoslavtsenov/enable-naviagtion-tests-android build_nativescript_angular#svetoslavtsenov/enable-naviagtion-tests-android

@SvetoslavTsenov

This comment has been minimized.

Copy link
Contributor

SvetoslavTsenov commented Nov 5, 2018

test ngapps#svetoslavtsenov/enable-naviagtion-tests-android build_nativescript-angular#svetoslavtsenov/enable-naviagtion-tests-android

@manoldonev manoldonev merged commit 41ba93d into master Nov 5, 2018

2 of 3 checks passed

ci/jenkins/core-modules-tests FAILed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@manoldonev manoldonev deleted the mdonev/child-already-has-a-parent-fix branch Nov 5, 2018

@wafflebot wafflebot bot removed the in progress label Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.