fix(android) Connectivity reporting none on resume #9915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| onCapabilitiesChanged(network: android.net.Network, networkCapabilities: android.net.NetworkCapabilities) { | ||
| console.log('NetworkCallbackImpl.onCapabilitiesChanged'); |
There was a problem hiding this comment.
could you remove the console.log ?
There was a problem hiding this comment.
Don't know how I missed that, gone now.
NathanWalker
pushed a commit
that referenced
this pull request
Jul 9, 2022
NathanWalker
pushed a commit
that referenced
this pull request
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On some android phones, (Google Pixel 5 & Galaxy s20+ running android 12) the final state reported when subscribing to
Connectivity.startMonitoringwould report incorrectly report no connectivity.This happened when the app was in the foreground, and the phone was locked and then unlocked ( i.e. hit power button)
This was because the call to the methods on ConnectivityManager.getActiveNetwork returned null, the documentation seems to suggest that calling any of the syncronus methods on ConnectivityManager is not advised during these callbacks.
https://developer.android.com/reference/android/net/ConnectivityManager.NetworkCallback
What is the new behavior?
The new behaviour is to rely on the network capabilities passed to the callback to determine the status, or to report no connectivity when lost is triggered.
Fixes/Implements/Closes #[Issue Number].