fix: websocket check to prevent runtime conflict on network framework#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser-compatible
WebSocketimplementation in thecreateInspectorSocketfunction to prevent runtime errors when running in environments where a non-browser globalWebSocketis present, such as NativeScript on iOS. The main change is the introduction of a stricter check for a browser-styleWebSocketbefore attempting to instantiate it.WebSocket environment detection improvements:
typeof WebSocket === "function"check with a newisBrowserWebSocketfunction inindex.tsto ensure the globalWebSocketis compatible with browser APIs before using it. This prevents instantiation errors with native classes that are not true WebSocket polyfills.isBrowserWebSockethelper function, which checks for browser-style readyState constants (CONNECTING,OPEN) and the presence ofsendandclosemethods on the prototype, ensuring only real browser WebSocket polyfills are used.