From faf1a8036742670c00ef518353069f3348d11a84 Mon Sep 17 00:00:00 2001 From: Manol Donev Date: Tue, 23 Oct 2018 13:30:27 +0300 Subject: [PATCH 1/2] feat: bump supportVer fallback value to 28.0.0 --- test-app/app/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-app/app/build.gradle b/test-app/app/build.gradle index 492553b8f..325730dad 100644 --- a/test-app/app/build.gradle +++ b/test-app/app/build.gradle @@ -257,7 +257,7 @@ repositories { } dependencies { - def supportVer = "27.0.1" + def supportVer = "28.0.0" if (project.hasProperty("supportVersion")) { supportVer = supportVersion } From 3eb96f681ee7cbc5f1a4499c0f62c11195e3e2b0 Mon Sep 17 00:00:00 2001 From: Darin Dimitrov Date: Tue, 23 Oct 2018 16:24:35 +0300 Subject: [PATCH 2/2] Update default compile and target SDK versions to 28 --- test-app/app/build.gradle | 6 +++--- test-app/runtime/build.gradle | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test-app/app/build.gradle b/test-app/app/build.gradle index 325730dad..59060e01c 100644 --- a/test-app/app/build.gradle +++ b/test-app/app/build.gradle @@ -72,10 +72,10 @@ version of the {N} CLI install a previous version of the runtime package - 'tns project.ext.extractedDependenciesDir = "${project.buildDir}/exploded-dependencies" def nativescriptDependencies = new JsonSlurper().parseText(dependenciesJson.text) -def computeCompileSdkVersion = { -> project.hasProperty("compileSdk") ? compileSdk : 26 } -def computeTargetSdkVersion = { -> project.hasProperty("targetSdk") ? targetSdk : 26 } +def computeCompileSdkVersion = { -> project.hasProperty("compileSdk") ? compileSdk : 28 } +def computeTargetSdkVersion = { -> project.hasProperty("targetSdk") ? targetSdk : 28 } def computeBuildToolsVersion = { -> - project.hasProperty("buildToolsVersion") ? buildToolsVersion : "28.0.2" + project.hasProperty("buildToolsVersion") ? buildToolsVersion : "28.0.3" } project.ext.selectedBuildType = project.hasProperty("release") ? "release" : "debug" diff --git a/test-app/runtime/build.gradle b/test-app/runtime/build.gradle index 245c62725..b9ce2782f 100644 --- a/test-app/runtime/build.gradle +++ b/test-app/runtime/build.gradle @@ -20,7 +20,7 @@ if (useCCache) { println "Use CCache build triggered." } -project.ext._buildToolsVersion = "28.0.2" +project.ext._buildToolsVersion = "28.0.3" android { sourceSets {