From b00a218763a0ace00451036192a077779abb895c Mon Sep 17 00:00:00 2001 From: blagoev Date: Wed, 23 Mar 2016 11:43:43 +0200 Subject: [PATCH 1/2] Enable JsDebugger on first debugger connect (do not stop on debugger; statements when no debugging is intended). --- src/src/com/tns/JsDebugger.java | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/src/com/tns/JsDebugger.java b/src/src/com/tns/JsDebugger.java index 7fa216a9a..9229b833d 100644 --- a/src/src/com/tns/JsDebugger.java +++ b/src/src/com/tns/JsDebugger.java @@ -59,6 +59,8 @@ public class JsDebugger private byte[] LINE_END_BYTES; private HandlerThread handlerThread; + + public boolean jsDebuggerEnabled; public JsDebugger(Context context, Logger logger, ThreadScheduler threadScheduler) { @@ -124,7 +126,12 @@ public void close() throws IOException try { LocalSocket socket = serverSocket.accept(); - + + if (!jsDebuggerEnabled) + { + enable(); + } + logger.write("NativeScript Debugger new connection on: " + socket.getFileDescriptor().toString()); //out (send messages to node inspector) @@ -492,6 +499,7 @@ private void enableAgent() { logger.write("Enabling NativeScript Debugger Agent"); enable(); + jsDebuggerEnabled = true; } @RuntimeCallable @@ -499,7 +507,7 @@ private void disableAgent() { logger.write("Disabling NativeScript Debugger Agent"); disable(); - + jsDebuggerEnabled = true; String message = "{\"seq\":0,\"type\":\"request\",\"command\":\"disconnect\"}"; @@ -580,12 +588,13 @@ public void start() registerEnableDisableDebuggerReceiver(handler); - logger.write("Enabling Debugger Agent"); - enable(); - boolean shouldDebugBrake = getDebugBreakFlagAndClearIt(); if (shouldDebugBrake) { + logger.write("Enabling Debugger Agent"); + enable(); + jsDebuggerEnabled = true; + debugBreak(); } } From c40059dce15c6a31f4bb36625c10b04e32c94cf2 Mon Sep 17 00:00:00 2001 From: blagoev Date: Wed, 23 Mar 2016 13:56:31 +0200 Subject: [PATCH 2/2] remove js debugger disable flagging --- src/src/com/tns/JsDebugger.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/src/com/tns/JsDebugger.java b/src/src/com/tns/JsDebugger.java index 9229b833d..f8a361949 100644 --- a/src/src/com/tns/JsDebugger.java +++ b/src/src/com/tns/JsDebugger.java @@ -507,7 +507,6 @@ private void disableAgent() { logger.write("Disabling NativeScript Debugger Agent"); disable(); - jsDebuggerEnabled = true; String message = "{\"seq\":0,\"type\":\"request\",\"command\":\"disconnect\"}";