From 391b7bdc378755c547157ba84281fc953becb2fc Mon Sep 17 00:00:00 2001 From: Michael DeGiovanni Date: Sat, 27 Nov 2021 12:56:00 +0100 Subject: [PATCH 1/4] Update Readme.md for Facebook authentication --- packages/firebase-auth/README.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/firebase-auth/README.md b/packages/firebase-auth/README.md index 8df3fe5c..29b2cbf7 100644 --- a/packages/firebase-auth/README.md +++ b/packages/firebase-auth/README.md @@ -162,15 +162,13 @@ import { LoginManager, AccessToken } from '@nativescript/facebook'; LoginManager.logInWithPermissions(['public_profile', 'email']).then((result) => { // Once signed in, get the users AccesToken - const data = await AccessToken.getCurrentAccessToken(); + const data = await AccessToken.currentAccessToken(); // Create a Firebase credential with the AccessToken - const facebookCredential = FacebookAuthProvider.credential(data.accessToken); + const facebookCredential = FacebookAuthProvider.credential(data.tokenString); // Sign-in the user with the credential - return auth().signInWithCredential(facebookCredential); - - firebase().auth().signInWithCredential(facebookAuthCredential); + return firebase().auth().signInWithCredential(facebookCredential); }); From d6f2d3bd982fa7372bb9cb8321359f2147ae66ac Mon Sep 17 00:00:00 2001 From: Michael DeGiovanni Date: Sat, 27 Nov 2021 12:56:46 +0100 Subject: [PATCH 2/4] Update import file for messaging --- packages/firebase-messaging/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase-messaging/README.md b/packages/firebase-messaging/README.md index 2be25de0..3ac93d91 100644 --- a/packages/firebase-messaging/README.md +++ b/packages/firebase-messaging/README.md @@ -22,7 +22,7 @@ This module provides a requestPermission method which triggers a native permissi ```ts import { firebase } from '@nativescript/firebase-core'; -import '@nativescript/firebase-crashlytics'; // only needs to be imported 1x +import '@nativescript/firebase-messaging'; // only needs to be imported 1x async function requestUserPermission() { const authStatus = await firebase() From 264c166ae7a6884f0cfdfac5b42760e1b0f14ffe Mon Sep 17 00:00:00 2001 From: Michael DeGiovanni Date: Sat, 27 Nov 2021 13:06:23 +0100 Subject: [PATCH 3/4] Fix onTokenRefresh to onToken --- packages/firebase-messaging/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase-messaging/README.md b/packages/firebase-messaging/README.md index 3ac93d91..18f4b23e 100644 --- a/packages/firebase-messaging/README.md +++ b/packages/firebase-messaging/README.md @@ -263,7 +263,7 @@ async function saveTokenToDatabase(token) { // Listen to whether the token changes - firebase().messaging().onTokenRefresh(token => { + firebase().messaging().onToken(token => { saveTokenToDatabase(token); } From aad61f5977f79a9bc6d94b895f4eb373388ccbcf Mon Sep 17 00:00:00 2001 From: Michael DeGiovanni Date: Sat, 27 Nov 2021 14:20:21 +0100 Subject: [PATCH 4/4] Update README.md --- packages/firebase-auth/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase-auth/README.md b/packages/firebase-auth/README.md index 29b2cbf7..137a4556 100644 --- a/packages/firebase-auth/README.md +++ b/packages/firebase-auth/README.md @@ -225,7 +225,7 @@ import { GoogleSignin } from '@nativescript/google-signin'; GoogleSignin.configure(); // called earlier in the app GoogleSignin.signIn().then((user) => { - const credential = GoogleAuthProvider.credential(user.accessToken, user.idToken); + const credential = GoogleAuthProvider.credential(user.idToken, user.accessToken); firebase().auth().signInWithCredential(credential); });