feat: update other deps and remove comments (#215)

NathanWalker · web-flow · commit 1e4fc6cd35a3 · 2022-07-31T11:01:54.000-07:00
diff --git a/packages/template-blank-svelte/app/app.css b/packages/template-blank-svelte/app/app.css
@@ -1,19 +1,6 @@
-﻿/*
-In NativeScript, the app.css file is where you place CSS rules that
-you would like to apply to your entire application. Check out
-http://docs.nativescript.org/ui/styling for a full list of the CSS
-selectors and properties you can use to style UI components.
-
-/*
-In many cases you may want to use the NativeScript core theme instead
-of writing your own CSS rules. For a full list of class names in the theme
-refer to http://docs.nativescript.org/ui/theme.
-The imported CSS rules must precede all other types of rules.
-*/
-@import '@nativescript/theme/css/core.css';
+﻿@import '@nativescript/theme/css/core.css';
 @import '@nativescript/theme/css/default.css';
 
-/* Font icon class */
 .fab {
   font-family: 'Font Awesome 5 Brands', 'fa-brands-400';
   font-weight: 400;
diff --git a/packages/template-blank-svelte/package.json b/packages/template-blank-svelte/package.json
@@ -3,7 +3,7 @@
   "main": "app/app.ts",
   "displayName": "Blank Svelte",
   "templateType": "App template",
-  "version": "8.2.1",
+  "version": "8.2.2",
   "description": "Blank template for NativeScript apps using Svelte",
   "author": "NativeScript Team <oss@nativescript.org>",
   "license": "Apache-2.0",
diff --git a/packages/template-drawer-navigation-ng/package.json b/packages/template-drawer-navigation-ng/package.json
@@ -3,7 +3,7 @@
   "main": "src/main.ts",
   "displayName": "Navigation Drawer",
   "templateType": "App template",
-  "version": "8.2.3",
+  "version": "8.2.4",
   "description": "Side navigation template",
   "author": "NativeScript Team <oss@nativescript.org>",
   "license": "Apache-2.0",
diff --git a/packages/template-drawer-navigation-ng/src/app/app.component.html b/packages/template-drawer-navigation-ng/src/app/app.component.html
@@ -1,8 +1,3 @@
-<!--
-RadSideDrawer is a UI component part of the Progress NativeScript UI set of components.
-Learn more about the RadSideDrawer UI component and how it can be customized in this documentation article:
-https://docs.nativescript.org/angular/ui/professional-ui-components/ng-SideDrawer/getting-started
--->
 <RadSideDrawer [drawerTransition]="sideDrawerTransition">
   <GridLayout tkDrawerContent rows="auto, *" class="nt-drawer__content">
     <StackLayout row="0" class="nt-drawer__header">
diff --git a/packages/template-drawer-navigation-ts/package.json b/packages/template-drawer-navigation-ts/package.json
@@ -3,7 +3,7 @@
   "main": "src/main.ts",
   "displayName": "Navigation Drawer",
   "templateType": "App template",
-  "version": "8.2.1",
+  "version": "8.2.2",
   "description": "Side navigation template",
   "author": "NativeScript Team <oss@nativescript.org>",
   "license": "Apache-2.0",
diff --git a/packages/template-drawer-navigation-ts/src/app-root/app-root.xml b/packages/template-drawer-navigation-ts/src/app-root/app-root.xml
@@ -1,8 +1,3 @@
-<!--
-RadSideDrawer is a UI component part of the Progress NativeScript UI set of components.
-Learn more about the RadSideDrawer UI component and how it can be customized in this documentation article:
-https://docs.nativescript.org/ui/professional-ui-components/SideDrawer/getting-started
--->
 <nsDrawer:RadSideDrawer
   id="sideDrawer"
   xmlns:nsDrawer="nativescript-ui-sidedrawer"
diff --git a/packages/template-drawer-navigation/app/app-root/app-root.xml b/packages/template-drawer-navigation/app/app-root/app-root.xml
@@ -1,8 +1,3 @@
-<!--
-RadSideDrawer is a UI component part of the Progress NativeScript UI set of components.
-Learn more about the RadSideDrawer UI component and how it can be customized in this documentation article:
-https://docs.nativescript.org/ui/professional-ui-components/SideDrawer/getting-started
--->
 <nsDrawer:RadSideDrawer
   id="sideDrawer"
   xmlns:nsDrawer="nativescript-ui-sidedrawer"
diff --git a/packages/template-drawer-navigation/package.json b/packages/template-drawer-navigation/package.json
@@ -3,7 +3,7 @@
   "main": "app/app.js",
   "displayName": "Navigation Drawer",
   "templateType": "App template",
-  "version": "8.2.1",
+  "version": "8.2.2",
   "description": "Side navigation template",
   "author": "NativeScript Team <oss@nativescript.org>",
   "license": "Apache-2.0",
diff --git a/packages/template-hello-world-ng/package.json b/packages/template-hello-world-ng/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@nativescript/template-hello-world-ng",
   "main": "./src/main.ts",
-  "version": "8.2.3",
+  "version": "8.2.4",
   "author": "NativeScript Team <oss@nativescript.org>",
   "description": "NativeScript Angular Hello World template",
   "license": "Apache-2.0",
diff --git a/packages/template-hello-world-ng/src/app.css b/packages/template-hello-world-ng/src/app.css
@@ -1,25 +1,6 @@
-/*
-In NativeScript, the app.css file is where you place CSS rules that
-you would like to apply to your entire application. Check out
-http://docs.nativescript.org/ui/styling for a full list of the CSS
-selectors and properties you can use to style UI components.
-
-/*
-In many cases you may want to use the NativeScript core theme instead
-of writing your own CSS rules. You can learn more about the
-NativeScript core theme at https://github.com/nativescript/theme
-The imported CSS rules must precede all other types of rules.
-*/
 @import '@nativescript/theme/css/core.css';
 @import '@nativescript/theme/css/default.css';
 
-/* Place any CSS rules you want to apply on both iOS and Android here.
-This is where the vast majority of your CSS code goes. */
-
-/*
-The following CSS rule changes the font size of all Buttons that have the
-"-primary" class modifier.
-*/
 Button.-primary {
   font-size: 18;
 }
diff --git a/packages/template-hello-world-ng/src/app/item/items.component.html b/packages/template-hello-world-ng/src/app/item/items.component.html
@@ -1,27 +1,5 @@
-<!--
-The template defines the view of the component - what is actually rendered.
-In NativeScript applications the template is defined with XML using NativeScript UI elements.
-It is different from HTML. So instead of <input>, <span>, <div> etc. - we have <TextField>, <Label> and layouts.
-The important thing is that although the elements are different - all of the Angular’s template syntax works exactly the same.
-So you can still use template expressions, bindings, templates as well as all the built-in directives.
--->
-
-<!--
-The ActionBar is the NativeScript common abstraction over the Android ActionBar and iOS NavigationBar.
-http://docs.nativescript.org/ui/action-bar
--->
 <ActionBar title="My App"> </ActionBar>
 
-<!--
-The GridLayout arranges its child elements in a table structure of rows and columns.
-A cell can contain multiple child elements, they can span over multiple rows and columns,
-and even overlap each other. The GridLayout has one column and one row by default.
-You can learn more about NativeScript layouts at https://docs.nativescript.org/ui/layout-containers.
-
-These components make use of the NativeScript core theme, which styles them with element selectors.
-The theme also provides a set of helper class names such as p-20, h1, h2, and text-center to enhance styling.
-You can learn more about the NativeScript core theme at https://github.com/nativescript/theme
--->
 <GridLayout>
   <ListView [items]="items">
     <ng-template let-item="item">
diff --git a/packages/template-hello-world-ts/app/app.css b/packages/template-hello-world-ts/app/app.css
@@ -1,25 +1,6 @@
-﻿/*
-In NativeScript, the app.css file is where you place CSS rules that
-you would like to apply to your entire application. Check out
-http://docs.nativescript.org/ui/styling for a full list of the CSS
-selectors and properties you can use to style UI components.
-
-/*
-In many cases you may want to use the NativeScript core theme instead
-of writing your own CSS rules. You can learn more about the
-NativeScript core theme at https://github.com/nativescript/theme
-The imported CSS rules must precede all other types of rules.
-*/
-@import '@nativescript/theme/css/core.css';
+﻿@import '@nativescript/theme/css/core.css';
 @import '@nativescript/theme/css/default.css';
 
-/* Place any CSS rules you want to apply on both iOS and Android here.
-This is where the vast majority of your CSS code goes. */
-
-/*
-The following CSS rule changes the font size of all Buttons that have the
-'-primary' class modifier.
-*/
 Button.-primary {
   font-size: 18;
 }
diff --git a/packages/template-hello-world-ts/app/main-page.ts b/packages/template-hello-world-ts/app/main-page.ts
@@ -1,30 +1,7 @@
-/*
-In NativeScript, a file with the same name as an XML file is known as
-a code-behind file. The code-behind is a great place to place your view
-logic, and to set up your page’s data binding.
-*/
-
 import { EventData, Page } from '@nativescript/core'
 import { HelloWorldModel } from './main-view-model'
 
-// Event handler for Page 'navigatingTo' event attached in main-page.xml
 export function navigatingTo(args: EventData) {
-  /*
-    This gets a reference this page’s <Page> UI component. You can
-    view the API reference of the Page to see what’s available at
-    https://docs.nativescript.org/api-reference/classes/_ui_page_.page.html
-    */
   const page = <Page>args.object
-
-  /*
-    A page’s bindingContext is an object that should be used to perform
-    data binding between XML markup and TypeScript code. Properties
-    on the bindingContext can be accessed using the {{ }} syntax in XML.
-    In this example, the {{ message }} and {{ onTap }} bindings are resolved
-    against the object returned by createViewModel().
-
-    You can learn more about data binding in NativeScript at
-    https://docs.nativescript.org/core-concepts/data-binding.
-    */
   page.bindingContext = new HelloWorldModel()
 }
diff --git a/packages/template-hello-world-ts/app/main-page.xml b/packages/template-hello-world-ts/app/main-page.xml
@@ -1,27 +1,6 @@
-<!--
-The markup in NativeScript apps contains a series of user interface components, each
-of which NativeScript renders with a platform-specific iOS or Android native control.
-You can find a full list of user interface components you can use in your app at
-https://docs.nativescript.org/ui/components.
--->
 <Page xmlns="http://schemas.nativescript.org/tns.xsd" navigatingTo="navigatingTo">
-    <!--
-    The ActionBar is the NativeScript common abstraction over the Android ActionBar and iOS NavigationBar.
-    http://docs.nativescript.org/ui/action-bar
-    -->
     <ActionBar title="My App" icon="" />
 
-    <!--
-    The StackLayout stacks UI components on the screen—either vertically or horizontally.
-    In this case, the StackLayout does vertical stacking; you can change the stacking to
-    horizontal by applying a orientation="horizontal" attribute to the <StackLayout> element.
-    You can learn more about NativeScript layouts at
-    https://docs.nativescript.org/ui/layout-containers.
-
-    These components make use of the NativeScript core theme, which styles them with element selectors.
-    The theme also provides a set of helper class names such as p-20, h1, h2, and text-center to enhance styling.
-    You can learn more about the NativeScript core theme at https://github.com/nativescript/theme
-    -->
     <StackLayout class="p-20">
         <Label text="Tap the button" class="h1 text-center" />
         <Button text="TAP" tap="{{ onTap }}" class="-primary" />
diff --git a/packages/template-hello-world-ts/package.json b/packages/template-hello-world-ts/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@nativescript/template-hello-world-ts",
   "main": "app/app.ts",
-  "version": "8.2.1",
+  "version": "8.2.2",
   "author": "NativeScript Team <oss@nativescript.org>",
   "description": "Nativescript hello-world-ts project template",
   "license": "Apache-2.0",
diff --git a/packages/template-hello-world/app/app.css b/packages/template-hello-world/app/app.css
@@ -1,25 +1,6 @@
-﻿/*
-In NativeScript, the app.css file is where you place CSS rules that
-you would like to apply to your entire application. Check out
-http://docs.nativescript.org/ui/styling for a full list of the CSS
-selectors and properties you can use to style UI components.
-
-/*
-In many cases you may want to use the NativeScript core theme instead
-of writing your own CSS rules. You can learn more about the
-NativeScript core theme at https://github.com/nativescript/theme
-The imported CSS rules must precede all other types of rules.
-*/
-@import '@nativescript/theme/css/core.css';
+﻿@import '@nativescript/theme/css/core.css';
 @import '@nativescript/theme/css/default.css';
 
-/* Place any CSS rules you want to apply on both iOS and Android here.
-This is where the vast majority of your CSS code goes. */
-
-/*
-The following CSS rule changes the font size of all Buttons that have the
-"-primary" class modifier.
-*/
 Button.-primary {
   font-size: 18;
 }
diff --git a/packages/template-hello-world/app/main-page.js b/packages/template-hello-world/app/main-page.js
@@ -1,40 +1,6 @@
-/*
-In NativeScript, a file with the same name as an XML file is known as
-a code-behind file. The code-behind is a great place to place your view
-logic, and to set up your page’s data binding.
-*/
-
-/*
-NativeScript adheres to the CommonJS specification for dealing with
-JavaScript modules. The CommonJS require() function is how you import
-JavaScript modules defined in other files.
-*/
 import { createViewModel } from './main-view-model';
 
 export function onNavigatingTo(args) {
-  /*
-    This gets a reference this page’s <Page> UI component. You can
-    view the API reference of the Page to see what’s available at
-    https://docs.nativescript.org/api-reference/classes/_ui_page_.page.html
-    */
   const page = args.object
-
-  /*
-    A page’s bindingContext is an object that should be used to perform
-    data binding between XML markup and JavaScript code. Properties
-    on the bindingContext can be accessed using the {{ }} syntax in XML.
-    In this example, the {{ message }} and {{ onTap }} bindings are resolved
-    against the object returned by createViewModel().
-
-    You can learn more about data binding in NativeScript at
-    https://docs.nativescript.org/core-concepts/data-binding.
-    */
   page.bindingContext = createViewModel()
 }
-
-/*
-Exporting a function in a NativeScript code-behind file makes it accessible
-to the file’s corresponding XML file. In this case, exporting the onNavigatingTo
-function here makes the navigatingTo="onNavigatingTo" binding in this page’s XML
-file work.
-*/
diff --git a/packages/template-hello-world/app/main-page.xml b/packages/template-hello-world/app/main-page.xml
@@ -1,27 +1,6 @@
-<!--
-The markup in NativeScript apps contains a series of user interface components, each
-of which NativeScript renders with a platform-specific iOS or Android native control.
-You can find a full list of user interface components you can use in your app at
-https://docs.nativescript.org/ui/components.
--->
 <Page xmlns="http://schemas.nativescript.org/tns.xsd" navigatingTo="onNavigatingTo">
-    <!--
-    The ActionBar is the NativeScript common abstraction over the Android ActionBar and iOS NavigationBar.
-    http://docs.nativescript.org/ui/action-bar
-    -->
     <ActionBar title="My App" icon="" />
 
-    <!--
-    The StackLayout stacks UI components on the screen—either vertically or horizontally.
-    In this case, the StackLayout does vertical stacking; you can change the stacking to
-    horizontal by applying a orientation="horizontal" attribute to the <StackLayout> element.
-    You can learn more about NativeScript layouts at
-    https://docs.nativescript.org/ui/layout-containers.
-
-    These components make use of the NativeScript core theme, which styles them with element selectors.
-    The theme also provides a set of helper class names such as p-20, h1, h2, and text-center to enhance styling.
-    You can learn more about the NativeScript core theme at https://github.com/nativescript/theme
-    -->
     <StackLayout class="p-20">
         <Label text="Tap the button" class="h1 text-center" />
         <Button text="TAP" tap="{{ onTap }}" class="-primary" />
diff --git a/packages/template-hello-world/package.json b/packages/template-hello-world/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@nativescript/template-hello-world",
   "main": "app/app.js",
-  "version": "8.2.1",
+  "version": "8.2.3",
   "author": "NativeScript Team <oss@nativescript.org>",
   "description": "Nativescript hello-world project template",
   "license": "Apache-2.0",
diff --git a/packages/template-master-detail-ng/package.json b/packages/template-master-detail-ng/package.json
@@ -3,7 +3,7 @@
   "main": "src/main.ts",
   "displayName": "Master-Detail with Firebase",
   "templateType": "App template",
-  "version": "8.2.3",
+  "version": "8.2.4",
   "description": "Master-detail interface to display collection of items from json collection and inspect and edit selected item properties. ",
   "author": "NativeScript Team <oss@nativescript.org>",
   "license": "Apache-2.0",
@@ -53,7 +53,7 @@
     "@nativescript/core": "~8.3.0",
     "@nativescript/imagepicker": "~1.0.6",
     "@nativescript/theme": "~3.0.2",
-    "nativescript-ui-listview": "~10.1.0",
+    "nativescript-ui-listview": "~10.2.0",
     "rxjs": "~7.5.0",
     "zone.js": "~0.11.5"
   },
diff --git a/packages/template-master-detail-ng/src/app/cars/car-detail-edit/my-list-selector/my-list-selector.component.ts b/packages/template-master-detail-ng/src/app/cars/car-detail-edit/my-list-selector/my-list-selector.component.ts
@@ -8,12 +8,6 @@ import { MyListSelectorModalViewComponent } from './my-list-selector-modal-view.
 
 const capitalizeFirstLetter = (s) => s.charAt(0).toUpperCase() + s.slice(1)
 
-/* ***********************************************************
- * The MyListSelector custom component uses a {N} modal page to let the user select and option
- * from a list. You can also check out the my-list-selector-modal-view.component.ts to see the
- * contents of the modal page. Learn more about modal pages in this documentation article:
- * https://docs.nativescript.org/angular/code-samples/modal-page
- *************************************************************/
 @Component({
   providers: [ModalDialogService],
   selector: 'MyListSelector',
@@ -37,7 +31,6 @@ export class MyListSelectorComponent implements OnInit {
   ngOnInit(): void {
     let carId = ''
 
-    // use switchMap to get the latest activatedRoute instance
     this._pageRoute.activatedRoute
       .pipe(switchMap((activatedRoute) => activatedRoute.params))
       .forEach((params) => {
diff --git a/packages/template-master-detail-ng/src/app/cars/car-detail/car-detail.component.ts b/packages/template-master-detail-ng/src/app/cars/car-detail/car-detail.component.ts
diff --git a/packages/template-master-detail-ng/src/app/cars/car-list.component.html b/packages/template-master-detail-ng/src/app/cars/car-list.component.html
diff --git a/packages/template-master-detail-ts/package.json b/packages/template-master-detail-ts/package.json
diff --git a/packages/template-master-detail-vue/package.json b/packages/template-master-detail-vue/package.json
diff --git a/packages/template-master-detail/package.json b/packages/template-master-detail/package.json

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@nativescript/template-hello-world-ng",`
`3`	`3`	`"main": "./src/main.ts",`
`4`		`- "version": "8.2.3",`
	`4`	`+ "version": "8.2.4",`
`5`	`5`	`"author": "NativeScript Team <oss@nativescript.org>",`
`6`	`6`	`"description": "NativeScript Angular Hello World template",`
`7`	`7`	`"license": "Apache-2.0",`