Add tests for cli-3658 - Don't rebuild application for android when something is changed in App_Resources/ #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtopuzov
approved these changes
Jun 7, 2018
tests/emulator/run_android_tests.py
Outdated
| # Run again the app and ensure it's not rebuild | ||
| log3 = Tns.run_android(attributes={'--path': self.app_name, '--device': EMULATOR_ID}, wait=False, | ||
| assert_success=False) | ||
| strings = ['Skipping prepare', 'Refreshing application', |
Contributor
There was a problem hiding this comment.
Absolutely the same string array is defines a few lines above (line 721), no need to define same array again.
Natalia-Hristova
pushed a commit
that referenced
this pull request
Jun 19, 2018
…omething is changed in App_Resources/ (#139) * Add tests for cli-3658 * fix: reuse string
Natalia-Hristova
pushed a commit
that referenced
this pull request
Jun 28, 2018
…omething is changed in App_Resources/ (#139) * Add tests for cli-3658 * fix: reuse string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeScript/nativescript-cli#3658