Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(npm/pacote): allow tns to be able to use npm configuration properly #4905
What is the current behavior?
If you have a npm registry that is not hosted by npm, the TNS cli will fail to install npm modules.
However, apparently the tns cli uses pacote to verify the existence of the registry entry, BEFORE it adds it to the
As you can see from the image; npm actually found the package and installed it; but TNS failed and either rolls back the package.json change, or doesn't commit the package.json change.
What is the new behavior?
Upgraded to latest pacote library; and added ability to read npm configuration files (using the official libnpmconfig, which is then passed into pacote; so of course it now works properly. :-)
Thanks for reporting and handling this!
It looks OK for a patch release as it's really a bug fix, you just have to rebase the PR on our
We will run some tests after you rebase the changes on